Fix autocomplete when parameter appears in parenthesis#46
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CLI autocomplete parsing so option names inside parenthesized docopt groups do not include parentheses, and makes argument-description lookup robust when the current input contains regex metacharacters.
Changes:
- Normalizes docopt grouping separators before extracting option parameters.
- Switches zsh argument-description matching from regex grep to exact token matching with awk.
- Adds regression tests for parenthesized options and regex-like partial input.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
core/cli_root/autocomplete_helpers.sh |
Updates parameter extraction and argument-description lookup logic. |
tests/core/cli_root/test_autocomplete_helpers.sh |
Adds regression coverage for parenthesized option groups and invalid-regex-like input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+94
to
+95
| sed -E 's/^\[+// ; s/[=,].*$// ; s/\]+$//' | | ||
| grep -E -- '^--?[[:alnum:]_][[:alnum:]_-]*$' || : |
Owner
Author
There was a problem hiding this comment.
Probably we won't have this usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.