fix: Do not require start on checks that aren't expected to run - #457
Conversation
Signed-off-by: Eddie Knight <knight@linux.com>
|
CI is accurately failing on this because it triggers the breaking change indicators, as expected. The check does not need to be modified, but it also doesn't need to be regarded because this "breaking" fix corrects the behavior to the expected state. |
|
I'm inclined to agree. I linked an issue where we discussed the proper behavior previously. This probably needs to be tested with |
|
Agreed @jpower432 — I started on that after opening this PR, expecting it to be straightforward... but I'm not sure it is. This is the result of |
|
@jpower432 do you think it'd be better to just set |
CUE conditionals cause IncompleteKind, preventing Go struct generation. Move the "start required when executed" guard into #_AssessmentLogStrict (marked @go(-)) and apply it at the #ControlEvaluation level, keeping #AssessmentLog clean for codegen. Update compat test to handle hidden definition blocks: skip #_ defs in collectStableDefs and strip their structural noise in relaxForSubsume, the same treatment already applied for time.Format and list.Contains cross-context false positives. Assisted-by: Claude Code <noreply@anthropic.com>
|
@eddie-knight Take a look here. I tested it locally in Uses the same pattern as |
fix: separate start-time validation from Go codegen via hidden def
3 participants
Description
Do not require start time on checks that aren't expected to run.
Schema Changes
Schema Changes Made
auditlog.cue) changescapabilitycatalog.cue) changescontrolcatalog.cue) changesenforcementlog.cue) changesevaluationlog.cue) changesguidancecatalog.cue) changesmappingdocument.cue) changespolicy.cue) changesprinciplecatalog.cue) changesriskcatalog.cue) changesthreatcatalog.cue) changesvectorcatalog.cue) changesSchema Change Details
Previously start was always required. Now it isn't.
Testing
Related Issues
Reviewer Hints
Self-review checklist