Feat watch mode by sonic16x · Pull Request #804 · gemini-testing/html-reporter

sonic16x · 2026-09-02T18:29:28Z

Watch mode for gui mode.

Usage:
npx testplane gui --watch

Screen.Recording.2026-09-03.at.01.35.28.mov

pkg-pr-new · 2026-09-02T18:31:59Z

npm i https://pkg.pr.new/html-reporter@804

commit: dff7146

github-actions · 2026-09-02T18:32:50Z

✅ Component tests succeed

Report

github-actions · 2026-09-02T18:39:45Z

✅ E2E tests succeed

Report

KuznetsovRoman

I would appreciate more modular structure, where tests watcher would be pulled to separate module with short and concise module calls instead of being splattered all over the code base.

KuznetsovRoman · 2026-09-10T12:46:22Z


    await app.initialize();

+    if (args.cli.options.watch && toolAdapter.toolName === ToolName.Testplane) {


Its not the clean architecture i would like to see in html-reporter.
We have a lot of layers in html-reporter (server launches app, which manages tool-runner) to distribute responsibility between the layers, and you just pasted entire watcher in "gui/server.ts".

Now "server.ts" handles chokidar, calculates scope, manages debounce, drain the que, manages this "relatively low" level error handling...

Its clearly should be another module, and not "server.ts" responsibility.

Fixed. Moved watcher logic to separate TestsWatcher module. Now server.ts only creates and starts it.

KuznetsovRoman · 2026-09-10T13:41:27Z

+        const watchPaths = [...new Set([...config.getTestFilePatterns(), ...args.paths])];
+        const watchRoots = [...new Set(watchPaths.map(getWatchRoot).filter(Boolean))];


You are building watch roots, that may differ from real testplane scope:

If we have empty default set with files: [], your code gets empty array, while testplane reads default test directories

When running npx testplane gui tests/a.ts --watch, watches subscribes on all of the config globs, which is not what should be done here.

Selecting set through CLI call also is not considered

If path is set like "tests" without ending "/" or asterisks on the end, your "path.dirname('tests')" returns ".", so the watcher looks at all project files, including node_modules

Examples:
• getWatchRoot('tests') -> .
• getWatchRoot('tests/') -> tests
• getWatchRoot('tests/**/*.ts') -> tests

As a solution i see "creating watch plan in testplane adapter the same way test set is built for initial read". So it would be single source of truth, and not "couple of testfile finding mechanisms, which can work differently"

Fixed. Watch plan is now created in Testplane adapter. It handles CLI paths, selected sets, environment sets and default folders. Added tests for this cases.

KuznetsovRoman · 2026-09-10T15:31:45Z

+        let refreshSequence = 0;
+        let firstDebouncedEventAt: number | undefined;
+
+        const refresh = async (changedFiles: string[], removedDirectories: string[]): Promise<void> => {


There is a "catch" (thats a wordplay) in this function:
If some step, like, retrieving sqlite from history, fails, browser would only get "TESTS_REFRESH_FAILED" without actual tree patch. So if there was test A, which was renamed to test B, after the error browser would see test A, not test B, despite server collection would have the opposite: test B, not test A.

Trying to run test A would likely result in silent "nothing is really launched"

Fixed. Collection is updated only after successful tree update. If update fails, previous tree, test adapters and attempts are restored. Added test for this case.

KuznetsovRoman · 2026-09-10T15:33:45Z

+            }
+        }
+        const isChangedFile = (test: TestAdapter): boolean => affectedFiles.has(path.resolve(test.file));
+        const signature = (test: TestAdapter): string => JSON.stringify([test.browserId, path.resolve(test.file), test.titlePath]);


Your signature only includes "browserId", "resolved file" and "titlePath"
But tree building also consider "disabled", "silentlySkipped" and "pending"
For example, changing "it" to "it.skip" would have the exact signature and therefore would not refresh.

KuznetsovRoman · 2026-09-10T15:35:43Z

+        if (filesToRead.length) {
+            try {
+                stageStartedAt = performance.now();
+                changedCollection = await this._toolAdapter.readTests(filesToRead, this._globalOpts);


Shouldn't you separately check for "unique full name" here?
"readTests" under the hood checks for unique full names only for tests it currently read.
But you read only subset of tests and then combine it with previous tree without checking for fullName duplicates. It could potentially lead into some hard-to-debug problem.

Fixed. Partial update now checks duplicate test names in changed and unchanged files. Added test for this case.

KuznetsovRoman · 2026-09-10T15:39:45Z

+                    items: Object.keys(event.data.data).length
+                });
+            }
+            self.postMessage(true);


So now worker sends "true" on both "init" and "patch"

Existing "search" function in this file expects array of strings

If we get "true" from worker after search was initiated, "search" could confuse its response as "response to search" and fail due to "TypeError: array expected" or something like that.

I think we should move to typed messages: dispatching not just single "true", but whole object with "type" field in it in order to avoid confusion.

KuznetsovRoman · 2026-09-10T15:41:16Z

+        }
+    });
+
+    worker.postMessage({


Have you checked that "Test DOES appear when there was a filter, preventing from showing it, because its old name did not suite the filter, but the new one - does"?

Fixed. Worker messages now have type and requestId, so different responses are not mixed. Added test for this case.

KuznetsovRoman · 2026-09-10T15:43:28Z

+            }
+        };
+
+        testsWatcher = chokidar.watch(watchPaths, {


So, "chokidar.watch" errors crash the whole gui process. Is it expected? Is it like super stable so we wont expect it ever happening?

I would add some kind of "catch", at least for easier debugging (when somebody would see scary error message from chokidar.watch exception, he should at least understand that the error was because of some king of error in tree watcher)

Fixed. Current search filter runs again after search index update. Added test for renamed test case.

KuznetsovRoman · 2026-09-10T15:45:16Z

+        for (const {suitePath, browserId} of uniqueTests) {
+            const statement = this._db.prepare(
+                `SELECT * FROM ${DB_SUITES_TABLE_NAME} WHERE suitePath = ? AND name = ?`
+            );


Why are you doing N full scans? Its not clickhouse with its magic data skipping indexes. Its better to iterate through every "suite" once and filter everything you need by yourself, instead of torturing SQLite like that.

KuznetsovRoman · 2026-09-11T10:20:58Z

+                cwd: process.cwd(),
+                ignoreInitial: true,
+                ignored: [
+                    /(^|[/\\])\../,


Looks like it would ignore .tests/case.ts

We actually have some concrete examples: https://nda.ya.ru/t/VVkNi_VO7qaK7o

KuznetsovRoman · 2026-09-11T10:21:50Z

+const getTestStructureSignature = (test: TestAdapter): string => JSON.stringify([
+    test.browserId,
+    path.resolve(test.file),
+    test.titlePath,
+    test.disabled,
+    test.silentlySkipped,
+    test.pending
+]);


Maybe we should also add skip reason here?
Now skip reason update would not update real test in the tree because its not a part of the key

KuznetsovRoman · 2026-09-11T10:23:23Z

+                    logger.log(`[watch-perf][server][#${refreshId}] serialize/write SSE: ${(performance.now() - sendStartedAt).toFixed(1)}ms`);
+                }
+                logger.log(`[watch-perf][server][#${refreshId}] refresh loop total: ${(performance.now() - refreshStartedAt).toFixed(1)}ms ${JSON.stringify({changed})}`);


Those type of logs would be removed before merging, right?
If you want to leave them in the code, you should at least hide them in "debug"

Yea, I will remove it, it is just for review and tests

sonic16x force-pushed the watch-mode branch 3 times, most recently from 62eb636 to 54369aa Compare September 7, 2026 07:38

KuznetsovRoman requested changes Sep 10, 2026

View reviewed changes

rocketraccoon added 2 commits September 11, 2026 01:22

feat: watch mode

395c663

feat: watch mode fixes

4251ed5

sonic16x force-pushed the watch-mode branch from 54369aa to 4251ed5 Compare September 10, 2026 18:23

fix: pr fixes

dff7146

sonic16x force-pushed the watch-mode branch from 1926485 to dff7146 Compare September 10, 2026 21:35

KuznetsovRoman approved these changes Sep 11, 2026

View reviewed changes


		await app.initialize();

		if (args.cli.options.watch && toolAdapter.toolName === ToolName.Testplane) {

		const watchPaths = [...new Set([...config.getTestFilePatterns(), ...args.paths])];
		const watchRoots = [...new Set(watchPaths.map(getWatchRoot).filter(Boolean))];

Uh oh!

Conversation

sonic16x commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Component tests succeedReport

Uh oh!

github-actions Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ E2E tests succeedReport

Uh oh!

KuznetsovRoman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sonic16x commented Sep 2, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 2, 2026 •

edited

Loading

github-actions Bot commented Sep 2, 2026 •

edited

Loading

✅ Component tests succeed

Report

github-actions Bot commented Sep 2, 2026 •

edited

Loading

✅ E2E tests succeed

Report