chore: remove dead dupl exclusion and add warn-unused#631
Open
isaacschepp wants to merge 1 commit intomainfrom
Open
chore: remove dead dupl exclusion and add warn-unused#631isaacschepp wants to merge 1 commit intomainfrom
isaacschepp wants to merge 1 commit intomainfrom
Conversation
Remove `dupl` from the test-file exclusion list — it was never enabled as a linter, so the exclusion had no effect. Add `warn-unused: true` to the exclusions section so golangci-lint warns about dead exclusion rules in the future. Fixes #378
Deploying genealogix with
|
| Latest commit: |
2bf097d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dfeae2dc.genealogix.pages.dev |
| Branch Preview URL: | https://chore-remove-dead-dupl-exclu.genealogix.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the Go lint configuration by removing a linter exclusion that could never take effect and enabling detection of future “dead” exclusions in .golangci.yml.
Changes:
- Removed
duplfrom the_test\.goexclusion rule sinceduplisn’t enabled. - Added
warn-unused: trueunderlinters.exclusionsto surface unused exclusion rules going forward.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
duplfrom the test-file exclusion list — it was never enabled as a linter, so the rule had no effectwarn-unused: trueto the exclusions section so golangci-lint warns about dead exclusion rules in the futureFixes #378
Test plan
.golangci.ymlno longer referencesduplin exclusionswarn-unused: trueis present in the exclusions sectionduplwas never enabled, so removing its exclusion changes nothing