Remove completion overloads #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This feature was migrated from the previous code segment "if Client is SublimeText then ...". I don't know its function either; I just did it this way to avoid regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes what I think was a bad idea (the +1 overload text) and was broken during some refactors and caused this random "+ overload" string.
@zen010101 you made some Claude based changes that added two settings which I don't think we need so I removed them.
nullDocumentVersionisn't actually something you want to configure and was just a hack for SublimeText so I removed that (see the comment about OptionalVersionedTextDocumentIdentifier).filterTextOnlyis removed because it was just a hack around this bug I fixed here. Feels like that was just Claude slop to plug holes but feel free to give any input.Old code:
New code: