test(gen-models): demonstrate lack of delete tracking - #200
Draft
bobvh wants to merge 2 commits into
Draft
Conversation
Changeset reconstruction in process_changesetiter reads new_value() for every column, which a DELETE changeset item does not carry. Deleting a row inside an operation therefore panics with SQLITE_MISUSE at end_operation. Adds test_deleting_a_sample_cannot_be_tracked documenting that the operation layer is insert-only. No production code change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MbuLPbBBiZXJMqoUZhQ5DA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this when trying to implement deletion of a sample for python bindings: for operations reconstruction in process_changesetiter reads new_value() for every column, which a DELETE changeset item does not carry. Deleting a row inside an operation therefore panics with SQLITE_MISUSEre at end_operation.