Conversation
bobvh
commented
Jul 29, 2026
| - name: Install capnp (Windows) | ||
| if: runner.os == 'Windows' | ||
| run: choco install capnproto | ||
| - name: Stage bundled client (macOS) |
Member
Author
There was a problem hiding this comment.
This is something I wasn't able to test properly @dkhofer , how did you test this when you were doing this for the pkg?
Member
Author
There was a problem hiding this comment.
Learned more and promptly broke it, please disregard.
Member
Author
There was a problem hiding this comment.
Going to temporarily run it from the PR this one time to confirm that it works. It shouldn't push anything to pypi.
Member
Author
There was a problem hiding this comment.
Stage the Rust CLI in the Python package so pip, uv, and pipx install the gen command. Build abi3 wheels for Linux x86_64/aarch64, macOS arm64/x86_64, and Windows, then test them on Python 3.12 through 3.14. Sign and notarize macOS wheels for tagged releases. Upload release wheels after compatibility tests pass and send PyPI the exact producing run ID. Disable maturin sccache on Linux because before-script invokes Cargo before sccache is installed in the container. Keep manual tagged binary releases and nightly builds.
…tion Points at bobvh/rusqdoltlite@812ffae (fix-windows branch), which excludes Windows from the bundled remote-auth server build to avoid the pthread_t/struct DoltliteServer parse failure under MSVC. Revert this patch once the fix ships in a published crates.io release.
Drops the github.ref_type == 'tag' gate on the Sign/Notarize/Verify-signature steps so they run on this branch's CI. upload-release-wheels and trigger-pypi-publish keep their tag-only gates untouched, so this can't publish anything. Revert before merging.
…release tag" This reverts commit 8dc1618.
bobvh
commented
Jul 30, 2026
|
|
||
| [patch.crates-io] | ||
| # TEMPORARY: verifying the Windows MSVC build fix in CI before it's published | ||
| # to crates.io. Revert this patch before merging. |
Member
Author
There was a problem hiding this comment.
Only revert this if PR2 on rusqdoltlite has merged and published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea was to make installing gen as easy and non-threatening as possible.
Most users will be comfortable with a pip install, and you can include an executable binary alongside the python bindings.
I changed as little as possible, but did add a few extra builds to get to a crossplatform solution and not have it fail depending on your OS or python install. The abi3 switch was because the number of python builds was getting out of hand, I could revert it if needed.
tl;dr: