Refactor db graph code - #240
Open
dkhofer wants to merge 18 commits into
Open
Conversation
dkhofer
commented
Aug 5, 2026
| assert_eq!(nodes.len(), 5); | ||
|
|
||
| let second_update = update_with_vcf( | ||
| let _second_update = update_with_vcf( |
dkhofer
force-pushed
the
refactor-db-graph-code
branch
from
August 5, 2026 17:01
5a47a89 to
5daab09
Compare
dkhofer
commented
Aug 5, 2026
| @@ -0,0 +1,101 @@ | |||
| use core::fmt; | |||
Member
Author
There was a problem hiding this comment.
These got added here as part of the refactoring, to avoid circular dependencies. I think they could get moved back to gen-models now but I don't have a strong opinion
Member
Author
There was a problem hiding this comment.
Er, guess they came from gen-graph originally, maybe better to have them here than gen-models
dkhofer
commented
Aug 5, 2026
| @@ -0,0 +1,659 @@ | |||
| use std::collections::{HashMap, HashSet, VecDeque}; | |||
Member
Author
There was a problem hiding this comment.
I am open to better names for these files/modules and how the functions are organized within them, just wanted to extract this stuff out of models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.