Fix parsing of one-to-one metadata#388
Conversation
|
@marcellevstek Rebase, write change log entry, update docs (if needed). |
97dfd76 to
6c37e9a
Compare
|
@gregorjerse this PR addresses the issue when a one-to-one metadata table object includes samples that are either not present in the collection or don't have a required data object of certain process type (e.g. MultiQC). Previously the code failed, which posed an issue if some samples imported from GEO failed to process and we wanted to remove them from the collection. When you import through GEO, a one-to-one metadata table is created for each of the imported samples. Here is some testing code. Try it with this branch versus the master branch to see the difference. |
7a70e8c to
45b2df3
Compare
for samples with no data objects of certain process type or missing samples in the collection
45b2df3 to
32bb857
Compare
|
@gregorjerse please review. |
|
@gregorjerse ping. Review should only take a minute, it's just a few lines. |
gregorjerse
left a comment
There was a problem hiding this comment.
Code is fine as it is, just some comments.
No description provided.