Expose account servicer on Account DTO#184
Open
dereuromark wants to merge 1 commit into
Open
Conversation
Adds Account::getServicer(): ?FinancialInstitution, surfacing the <Acct><Svcr><FinInstnId> element from CAMT.052/053/054 messages. Reads BICFI (falling back to BIC) and Nm, so downstream consumers can obtain the servicing bank's BIC and name alongside the account identification.
Author
|
Tip: you can set in your settings, that "only new github users" are not allowed to run the CI pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements option C from #182: adds
Account::getServicer(): ?FinancialInstitution, surfacing the<Acct><Svcr><FinInstnId>element on the public DTO surface for CAMT.052, CAMT.053, and CAMT.054 messages.Downstream consumers can now obtain the servicing bank's BIC and name alongside the account identification, which is the common IBAN+BIC pair needed for reconciliation workflows.
What changed
Genkgo\Camt\DTO\FinancialInstitutionwithgetBic(): ?stringandgetName(): ?string.Accountgets a nullableservicerproperty withgetServicer()/setServicer().Decoder\Message::getAccountServicer()helper extractsBICFI(falling back toBIC) andNmfromSvcr/FinInstnId.addRecords()paths so the servicer is attached to whateverAccountsubclassgetAccount()returns (Iban, BBAN, UPIC, Proprietary, Other).