Draft
Conversation
37b71d7 to
72bcc48
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ml_genn_3 #183 +/- ##
=============================================
- Coverage 77.56% 77.40% -0.17%
=============================================
Files 114 114
Lines 4788 4833 +45
=============================================
+ Hits 3714 3741 +27
- Misses 1074 1092 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
72bcc48 to
3812d55
Compare
* Only -log() SCE loss, square MSE-adjacent losses * Only add per-trial loss once per-trial * Use seperate python classes for the two classes of loss function - MSE requires sqrt
bfbf363 to
1bef0b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some thought and fiddling, my conclusion is that loss is a compiler-specific thing and needs calculating in the backward pass so recording it isn't really something that can be easily or sensibly implemented as a metric. Therefore, this PR adds functionality to generate loss-calculating terms to the event prop backward pass and stores the data in a callback added by the compiler (in the same way rewiring stats are stored with Deep-R in #94).
However, I cannot quite figure out how all the calculations works in the original genn_eventprop code