Add --keep_going to make Bazel support more robust#288
Open
Silic0nS0ldier wants to merge 7 commits intogeorgewfraser:masterfrom
Open
Add --keep_going to make Bazel support more robust#288Silic0nS0ldier wants to merge 7 commits intogeorgewfraser:masterfrom
--keep_going to make Bazel support more robust#288Silic0nS0ldier wants to merge 7 commits intogeorgewfraser:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #287
With the changes in this PR, the language server works much better in the Bazel repository (provided
bazel build //src:bazel-devhas been run, otherwise the external dependencies aren't in the expected places).Also included in this PR;
4.2.4, which appears to be the version expected. Without this tests will fail due tobazelisk(from Github actions runners) will pull in the latest stable release (7.2.xat time of writing).