Use latest textmate grammar from redhat-developer/vscode-java#289
Open
Silic0nS0ldier wants to merge 3 commits intogeorgewfraser:masterfrom
Open
Use latest textmate grammar from redhat-developer/vscode-java#289Silic0nS0ldier wants to merge 3 commits intogeorgewfraser:masterfrom
Silic0nS0ldier wants to merge 3 commits intogeorgewfraser:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from https://github.com/redhat-developer/vscode-java/blob/70ebc3eec19f0e827734b9a20f016e92433c834d/language-support/java/java.tmLanguage.json, which is what the VSCode integrated Java textmate grammar uses.
This grammar covers many more language features (e.g. multi-line text blocks).
Differences I can see (not all shown in the screenshots) are;
classandinterfacedeclaration names.true/false/nullcolors now match that of other languages (now blue where before it was light green).classis now colored the same as normal properties (I'd personally classify this as a regression since the prior grammar explicitly classifies it askeyword.class, although this seems more like an opinion).There are likely plenty more differences. If a more exhaustive comparison is desired let me know and I'll get the current and proposed extensions running side-by-side (its a bit of work right now as 2 fully functional environments are required, doable but tedious).
Current
VSCode Builtin (Red Hat)
PR