Fix breakpoints in classes with inner/anonymous classes#314
Open
nya3jp wants to merge 2 commits intogeorgewfraser:masterfrom
Open
Fix breakpoints in classes with inner/anonymous classes#314nya3jp wants to merge 2 commits intogeorgewfraser:masterfrom
nya3jp wants to merge 2 commits intogeorgewfraser:masterfrom
Conversation
We used to have two scopes of variables, "locals" and "arguments". However, VM somehow returns incorrect results for LocalVariable#isArgument(), so we presented confusing views to users. Since it's not very important to distinguish arguments and local variables, we now include them in the same "locals" scope. Instead, we introduce the new "fields" scope containing fields of the current object (aka "this"). And finally, we now support inspecting the hierarchy of objects.
Existing breakpoint installation logic assumes that there is one-to-one correspondence between a class and a Java source file. But it does not hold for classes with inner classes and/or anonymous classes. This patch fixes the logic to handle the case. Also adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing breakpoint installation logic assumes that there is one-to-one correspondence between a class and a Java source file. But it does not hold for classes with inner classes and/or anonymous classes.
This patch fixes the logic to handle the case. Also adds a regression test.