I've added support for the CLASSPATH environment variable in InferCon…#323
Open
georgewfraser wants to merge 1 commit intomasterfrom
Open
I've added support for the CLASSPATH environment variable in InferCon…#323georgewfraser wants to merge 1 commit intomasterfrom
georgewfraser wants to merge 1 commit intomasterfrom
Conversation
…fig. This change modifies the `InferConfig` class to allow the Java language server to determine the project's classpath using the `CLASSPATH` environment variable. Key changes: - The `classPath()` method in `InferConfig.java` now checks for the `CLASSPATH` environment variable first. If set, its value is parsed and used as the classpath. This allows you to override the default classpath discovery mechanisms (Maven, Bazel). - `InferConfig.java` was refactored to allow injection of environment variables for testing purposes. This involved adding a new constructor that accepts a map of environment variables and updating methods that access environment variables to use this injected map. - A new unit test, `classpathFromEnvironmentVariable`, was added to `InferConfigTest.java` to specifically verify the new functionality. This test uses the new constructor to inject a mock `CLASSPATH` variable. All tests in `InferConfigTest.java`, including the new test, pass. Note: During testing, I observed three pre-existing test failures in other classes (`CompletionsTest.overloadedOnClassPath`, `FindSrcZipTest.testFindSrcZip`, `HoverTest.docString`). These failures are believed to be unrelated to the changes in this commit and should be investigated separately.
|
Tests seem not independent. I mentioned it at #313 [INFO] Results: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fig.
This change modifies the
InferConfigclass to allow the Java language server to determine the project's classpath using theCLASSPATHenvironment variable.Key changes:
classPath()method inInferConfig.javanow checks for theCLASSPATHenvironment variable first. If set, its value is parsed and used as the classpath. This allows you to override the default classpath discovery mechanisms (Maven, Bazel).InferConfig.javawas refactored to allow injection of environment variables for testing purposes. This involved adding a new constructor that accepts a map of environment variables and updating methods that access environment variables to use this injected map.classpathFromEnvironmentVariable, was added toInferConfigTest.javato specifically verify the new functionality. This test uses the new constructor to inject a mockCLASSPATHvariable.All tests in
InferConfigTest.java, including the new test, pass.Note: During testing, I observed three pre-existing test failures in other classes (
CompletionsTest.overloadedOnClassPath,FindSrcZipTest.testFindSrcZip,HoverTest.docString). These failures are believed to be unrelated to the changes in this commit and should be investigated separately.