Include dependencies and let some code more readable

loafer/managers.py

@@ -16,7 +16,7 @@ class LoaferManager:
 
     def __init__(self, routes, runner=None, _concurrency_limit=None, _max_threads=None):
         self._concurrency_limit = _concurrency_limit
-        if runner is None:
+        if not runner:
             self.runner = LoaferRunner(on_stop_callback=self.on_loop__stop, max_workers=_max_threads)
         else:
             self.runner = runner
@@ -62,7 +62,8 @@ def on_future__errors(self, future):
     def on_loop__stop(self, *args, **kwargs):
         logger.info('cancel dispatcher operations ...')
 
-        if hasattr(self, '_future'):
+        future = getattr(self, '_future', None)
+        if future:
             self._future.cancel()
 
         self.dispatcher.stop()

loafer/routes.py

@@ -51,18 +51,14 @@ def __str__(self):
             type(self).__name__, self.name, self.provider, self.handler)
 
     def apply_message_translator(self, message):
-        processed_message = {'content': message,
-                             'metadata': {}}
         if not self.message_translator:
-            return processed_message
+            return {'content': message, 'metadata': {}}
 
-        translated = self.message_translator.translate(processed_message['content'])
-        processed_message['metadata'].update(translated.get('metadata', {}))
-        processed_message['content'] = translated['content']
-        if not processed_message['content']:
+        translated = self.message_translator.translate(message)
+        if not translated['content']:
             raise ValueError('{} failed to translate message={}'.format(self.message_translator, message))
 
-        return processed_message
+        return translated
 
     async def deliver(self, raw_message):
         message = self.apply_message_translator(raw_message)
@@ -72,7 +68,7 @@ async def deliver(self, raw_message):
     async def error_handler(self, exc_info, message):
         logger.info('error handler process originated by message={}'.format(message))
 
-        if self._error_handler is not None:
+        if self._error_handler:
             return await run_in_loop_or_executor(self._error_handler, exc_info, message)
 
         return False

requirements/test.txt

@@ -2,6 +2,7 @@ pytest
 pytest-asyncio
 pytest-cov
 pytest-deadfixtures
+pytest-runner
 codecov
 asynctest
 pre-commit