feat: Generic Precision#234
Open
TurtIeSocks wants to merge 4 commits into
Open
Conversation
Author
|
Apologies for the tag @michaelkirk, but any feedback for this PR :) thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Following up from my post almost a year ago in #59 , I finally got around to finishing this up!
This adds support for the generic
CoordFloattrait to all structs provided by this crate. I've tested this locally in my OSS project and the only inconsistency I noticed was serializing with thejson!macro fromserde_jsonalways resulted inf64precision, but I wasn't sure if that is something that can be corrected in this crate. When returning the data and letting Actix serialize it with something likeHttpResponse::Ok().json(feature), it respected the intended precision.Notes for the maintainers to review:
f64defaults to make this a non-breaking change.:andwheresyntax, I tried to follow the code style as it was presented but let me know if anything should be adjusted.Resolves #59