re-export serde error#276
Merged
Merged
Conversation
Fixes #240 We are already re-exporting some serde objects, so this doesn't create a new semver contract that wasn't already there. And this way downstream users can interact with the error type without having to explicitly install serde_json.
michaelkirk
force-pushed
the
mkirk/re-export-serde-error
branch
from
84dfef6 to
76f5a4d
Compare
michaelkirk
commented
Apr 20, 2026
|
|
||
| pub type JsonValue = serde_json::Value; | ||
| pub type JsonObject = serde_json::Map<String, JsonValue>; | ||
| pub type MalformedGeoJsonError = serde_json::Error; |
Member
Author
There was a problem hiding this comment.
I struggled with the name a little bit. At first I though JsonError, but to me that implies only that there was some problem with the Json. However, we also use this to validate geojson schema - e.g. a missing "features" key for a feature collection. It's valid JSON, but not valid GeoJson.
urschrei
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Fixes #240
We are already re-exporting some serde objects, so this doesn't create a new semver contract that wasn't already there.
And this way downstream users can interact with the error type without having to explicitly install serde_json.