Conversation
|
I'm hoping this is related to #22 (comment) I'm eager to see how it shakes out - let me know if you'd like me to test something. |
28d6ea3 to
c3c4dec
Compare
|
It's slowly getting serious! Chaining like in #22 now supported. |
8dab8c5 to
8209707
Compare
michaelkirk
left a comment
There was a problem hiding this comment.
It's slowly getting serious! Chaining like in #22 now supported.
Nice! I've just taken a quick look at it, and it seems promising!
Do you think it's ready to attempt something like #36 (comment)? I can give it a try if you think so.
| // ------- Chain events ------- | ||
|
|
||
| /// Processing geometry events and passing events to a chained visitor | ||
| pub trait CĥainedGeomEventProcessor { |
There was a problem hiding this comment.
Oh wow, programming with diacritics! Exciting! 😉
Will have to support the event API in a format writer first. What's your favorite output format you want apply reprojection? geo-types? |
geo-types would be great! |
|
Testing the event API by implementing it for the FlatGeoBuf writer resulted in some major changes (e.g. bd3f1dd) and the following open points:
Ideas to investigate:
|
|
Experimental branch is kept in https://github.com/pka/geozero/tree/event-api |
This PR adds an event API, which should eventually replace the direct method call API. Main advandages are:
PromoteToMultiandLonLatToMercator)GeomVisitorstruct tracks main geometry type and collection flag, which can be used in format writersNext steps:
FeatureProcessorAPI. Should it be also event based?