Conversation
DimitriiTrater
force-pushed
the
add_support_for_kml_data
branch
2 times, most recently
from
d2da96c to
c0c6d3e
Compare
pjsier
requested changes
Oct 2, 2025
Member
pjsier
left a comment
pjsier
left a comment
There was a problem hiding this comment.
Thanks for the PR, and sorry for the delay! This is looking good, I just had a few questions but should be straightforward to clean up
DimitriiTrater
force-pushed
the
add_support_for_kml_data
branch
from
c0c6d3e to
ddbdd97
Compare
DimitriiTrater
force-pushed
the
add_support_for_kml_data
branch
from
ddbdd97 to
e2204ea
Compare
pjsier
approved these changes
Oct 3, 2025
Member
pjsier
left a comment
pjsier
left a comment
There was a problem hiding this comment.
Thanks for those changes! This looks great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdorCHANGELOG.mdfixes #32
kml:Data contains some attrs, so i added new method for ordering them ( im not sure about the need it, i didn't find anything similar in the code )
i dont know about < kml:DataExtension >…</kml:DataExtension>, in documentation i didn't find enough information to add support for it