make mapContainerId a configurable prop - #12877
Open
tha-nordiq wants to merge 2 commits into
Open
tha-nordiq wants to merge 2 commits into
tha-nordiq wants to merge 2 commits into
Conversation
6 tasks
Member
|
Thank you very much for your contribution to the MapStore codebase. We will review it as soon as possible. Many thanks. |
allyoucanmap
left a comment
allyoucanmap
left a comment
Contributor
There was a problem hiding this comment.
Hi @tha-nordiq, thanks for the contribution, I just added an inline question, thanks
| static propTypes = { | ||
| mapType: PropTypes.string, | ||
| map: PropTypes.object, | ||
| mapContainerId: PropTypes.string, |
Contributor
There was a problem hiding this comment.
Is this a prop provided via cfg? If so it would be better to have it documented in the JSDoc inside this file
Contributor
Author
There was a problem hiding this comment.
Good point!
yes you can control this via cfg
{
"name": "Map",
"cfg": {
"mapContainerId": "abc"
}
},ill update the inline doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the map container id is hardcoded as "map". this prevents having two separate maps embedded in a single webpage.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#12872
What is the current behavior?
the div container always has "map" as id
What is the new behavior?
you can now supply a mapContainerId prop to the map to get a different id.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
the change is backwards compatible.
Other useful information