Conversation
2 tasks
allyoucanmap
requested changes
Sep 17, 2026
Comment on lines
+193
to
+199
| * @prop {string} [cfg.id="mapstore-settings"] HTML identifier used by the panel or dialog wrapper. | ||
| * @prop {object} [cfg.style] Inline style applied to the settings content. The default width is 300 px. | ||
| * @prop {boolean} [cfg.wrap=false] If `true`, renders the content only while the Settings control is enabled and adds a panel or dialog wrapper. | ||
| * @prop {boolean} [cfg.wrapWithPanel=false] If `true` and `cfg.wrap` is enabled, uses a Bootstrap panel instead of a modal dialog rendered through a portal. | ||
| * @prop {object} [cfg.panelStyle] Inline style applied to the panel or dialog wrapper. By default it creates an absolutely positioned overlay with a minimum width of 300 px. | ||
| * @prop {string} [cfg.panelClassName="toolbar-panel"] CSS class applied to the panel or dialog wrapper. | ||
| * @prop {string} [cfg.closeGlyph="1-close"] Glyph used by the modal dialog close button. A falsy value renders the multiplication sign instead. |
Contributor
There was a problem hiding this comment.
I think we can remove these and just keep the overrideSettings below. The property listed here are mainly to change the style of the main component and I think it's better to now expose them for the moment
Contributor
Author
There was a problem hiding this comment.
Sure. I have done that. Thank You for your feedback!
Comment on lines
+201
to
+202
| * @prop {boolean} [cfg.overrideSettings.language] Shows or hides the language selector. If omitted from a custom override object, availability is inferred from the locale state. | ||
| * @prop {boolean} [cfg.overrideSettings.history] Shows or hides the undo/redo controls. If omitted from a custom override object, availability is inferred from map-history state. |
Contributor
There was a problem hiding this comment.
are these configurations still working?
Contributor
Author
There was a problem hiding this comment.
Yes they are working. I also verified by changing them in config. But I realized that availability is not inferred from the local state so I have simplified that statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds settings in context map setup wizard. And also updates docs about settings plugin
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#12889
What is the new behavior?
Settings have been added in burger menu
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)