fix(snapshot): auto-create dir in save(), return empty list in list_snapshot_files()#8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
save()andsave_any()now callcreate_dir_allbefore writing — no moreErr(NotFound)on first launch when the snapshot directory doesn't exist.list_snapshot_files()returnsOk(vec![])instead ofErr(NotFound)when the snapshot directory is absent.tests/snapshot.rs.Fixes #7.
Test plan
cargo test --features snapshot list_snapshot_files_missing_dir_returns_emptypassescargo test --features snapshot save_creates_missing_directorypassescargo test --features snapshot— full suite green (111 tests)cargo build --features snapshot— clean compile