Conversation
luckysori
force-pushed
the
chore/ln-dlc-node-deps-upgrade
branch
from
7723d10 to
2701cb6
Compare
da-kami
approved these changes
Mar 7, 2023
| version: "2.0.3" | ||
| sdks: | ||
| dart: ">=2.19.0 <4.0.0" | ||
| dart: ">=2.19.0 <3.0.0" |
Contributor
There was a problem hiding this comment.
🛠️ I don't think this change should be part of this PR. I keep running into this problem as well on my machine (somehow it is always changed back; but I think for @bonomat it is then changed back to 4.0.0 😅)
Contributor
Author
There was a problem hiding this comment.
I can remove it, but according to the pubspec.yaml, this change is correct:
environment:
sdk: ">=2.17.5 <3.0.0"If you play around with those constraints and you run flutter pub get the pubspec.lock changes as expected.
Most notably: - We now depend on the `split-tx-experiment` branch of `p2pderivatives/rust-lightning` fork. It appears that the changes we had in our fork are no longer needed and we need to update the dependency to be able to use the new branch of `rust-dlc`. - We've had to add our own `CustomSigner` and `CustomKeysManager` since `rust-dlc` no longer exports them. For now we have just inlined the implementations used in the `rust-dlc` tests.
We no longer need to patch the dependency after version 2.0 has been published.
This dependency should ideally only be known by core crates such as `ln-dlc-node`. We define a method `get_new_address` on `Node` so that we can control how we call the underlying on-chain wallet, rather than letting consumers call the wallet through a trait that is designed for a completely different purpose. We also turn the generic `get_dlcs` API into the more specific `get_confirmed_dlcs`, as this is the only thing that is currently needed. This way we can avoid consumers needing to understand types defined by `rust-dlc`. The `get_confirmed_dlcs` API and the matching `Dlc` type should evolve (and perhaps even disappear) as we meet new requirements.
luckysori
force-pushed
the
chore/ln-dlc-node-deps-upgrade
branch
from
2701cb6 to
09d9710
Compare
Contributor
Author
|
bors r+ |
Contributor
Author
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
rust-dlcbranch is still WIP, but it's good to keep this dependency up-to-date as much as possible.