Skip to content

feat(#540): replaced references to nwc.getalby.com#543

Merged
rolznz merged 1 commit intogetAlby:masterfrom
DSanich:feat/540-replace-references-to-nwc.getalby.com
Apr 15, 2026
Merged

feat(#540): replaced references to nwc.getalby.com#543
rolznz merged 1 commit intogetAlby:masterfrom
DSanich:feat/540-replace-references-to-nwc.getalby.com

Conversation

@DSanich
Copy link
Copy Markdown
Contributor

@DSanich DSanich commented Apr 14, 2026

Summary

Updates the getAuthorizationUrl unit test to use https://my.albyhub.com/apps/new instead of https://nwc.getalby.com/apps/new, which is no longer available.

Context

The old NWC app URL host has been shut down. The SDK already documents and uses Alby Hub’s auth path elsewhere (examples, docs, JSDoc on fromAuthorizationUrl / getAuthorizationUrl).

Closes #540

Changes

  • src/nwc/NWCClient.test.ts: swap the authorization base URL in the “standard url” test input and expected string to my.albyhub.com.

Testing

yarn test src/nwc/NWCClient.test.ts

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Tests**
  * Updated authorization endpoint verification in test suite.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8f5f1009-f21f-4153-abc1-ee716a7ef681

📥 Commits

Reviewing files that changed from the base of the PR and between 08a6cd7 and 764b02f.

📒 Files selected for processing (1)
  • src/nwc/NWCClient.test.ts

📝 Walkthrough

Walkthrough

Updated test expectations in NWCClient to reference my.albyhub.com instead of the deprecated nwc.getalby.com endpoint. Query parameters remain unchanged.

Changes

Cohort / File(s) Summary
Test URL Updates
src/nwc/NWCClient.test.ts
Updated authorization URL base endpoint from nwc.getalby.com to my.albyhub.com in test expectations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop and a skip, the URLs now gleam,
Old endpoints retired, a fresh hub dream,
From getalby's past to albyhub's way,
The tests pass on through another day! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly indicates the main change: replacing references to the deprecated nwc.getalby.com domain, directly matching the primary objective.
Linked Issues check ✅ Passed The PR fully addresses issue #540 by replacing nwc.getalby.com references in the test file with my.albyhub.com and updating the authorization URL accordingly.
Out of Scope Changes check ✅ Passed All changes are directly related to replacing the deprecated nwc.getalby.com with my.albyhub.com in the test expectations, with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thank you!

@rolznz rolznz merged commit da2352b into getAlby:master Apr 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace references to nwc.getalby.com

2 participants