fix: fix and improve test isolation and collision with environment

tests/antigravity-statusline.test.ts

@@ -16,9 +16,6 @@ describe('Antigravity CLI statusLine hook installer', () => {
     const settingsPath = join(dir, 'settings.json')
     const binDir = join(dir, 'bin')
     const codeburnPath = join(binDir, process.platform === 'win32' ? 'codeburn.cmd' : 'codeburn')
-    const oldSettingsPath = process.env['CODEBURN_ANTIGRAVITY_SETTINGS_PATH']
-    const oldCacheDir = process.env['CODEBURN_CACHE_DIR']
-    const oldPath = process.env.PATH
     await mkdir(binDir, { recursive: true })
     await writeFile(codeburnPath, process.platform === 'win32' ? '@echo off\r\n' : '#!/bin/sh\n')
     await chmod(codeburnPath, 0o755)
@@ -29,12 +26,6 @@ describe('Antigravity CLI statusLine hook installer', () => {
     try {
       await run(dir, settingsPath)
     } finally {
-      if (oldSettingsPath === undefined) delete process.env['CODEBURN_ANTIGRAVITY_SETTINGS_PATH']
-      else process.env['CODEBURN_ANTIGRAVITY_SETTINGS_PATH'] = oldSettingsPath
-      if (oldCacheDir === undefined) delete process.env['CODEBURN_CACHE_DIR']
-      else process.env['CODEBURN_CACHE_DIR'] = oldCacheDir
-      if (oldPath === undefined) delete process.env.PATH
-      else process.env.PATH = oldPath
       await rm(dir, { recursive: true, force: true })
     }
   }

tests/daily-cache.test.ts

@@ -45,7 +45,6 @@ beforeEach(() => {
 
 afterEach(async () => {
   vi.useRealTimers()
-  delete process.env['CODEBURN_CACHE_DIR']
   if (existsSync(TMP_CACHE_ROOT)) {
     await rm(TMP_CACHE_ROOT, { recursive: true, force: true })
   }

tests/models.test.ts

@@ -429,7 +429,6 @@ describe('DeepSeek v4 models resolve to pricing', () => {
   })
 
   it('keeps bundled DeepSeek v4 fallback entries when runtime pricing cache is stale', async () => {
-    const previousCacheDir = process.env['CODEBURN_CACHE_DIR']
     const cacheRoot = await mkdtemp(join(tmpdir(), 'codeburn-pricing-cache-'))
 
     try {
@@ -455,11 +454,6 @@ describe('DeepSeek v4 models resolve to pricing', () => {
       expect(getModelCosts('deepseek-v4-pro')!.inputCostPerToken).toBe(4.35e-7)
       expect(getModelCosts('deepseek-v4-flash')!.inputCostPerToken).toBe(1.4e-7)
     } finally {
-      if (previousCacheDir === undefined) {
-        delete process.env['CODEBURN_CACHE_DIR']
-      } else {
-        process.env['CODEBURN_CACHE_DIR'] = previousCacheDir
-      }
       await rm(cacheRoot, { recursive: true, force: true })
       await loadPricing()
     }

tests/optimize-fs.test.ts

@@ -19,8 +19,6 @@ import {
   detectBloatedClaudeMd,
   detectUnusedMcp,
   detectBashBloat,
-  detectGhostAgents,
-  detectGhostSkills,
   detectGhostCommands,
   loadMcpConfigs,
   scanJsonlFile,
@@ -217,16 +215,6 @@ describe('detectUnusedMcp', () => {
 // ============================================================================
 
 describe('detectBashBloat', () => {
-  const originalEnv = process.env['BASH_MAX_OUTPUT_LENGTH']
-
-  beforeEach(() => {
-    delete process.env['BASH_MAX_OUTPUT_LENGTH']
-  })
-
-  afterAll(() => {
-    if (originalEnv !== undefined) process.env['BASH_MAX_OUTPUT_LENGTH'] = originalEnv
-  })
-
   it('flags when env var is unset (uses default 30K)', () => {
     const finding = detectBashBloat()
     expect(finding).not.toBeNull()

tests/otel-cache-aggregation.test.ts

@@ -92,16 +92,12 @@ describe.skipIf(!isSqliteAvailable())(
     let tmpHome: string
     let tmpCache: string
     let dbPath: string
-    let prevHome: string | undefined
-    let prevCache: string | undefined
 
     beforeEach(async () => {
       tmpHome  = await mkdtemp(join(tmpdir(), 'cb-otel-agg-home-'))
       tmpCache = await mkdtemp(join(tmpdir(), 'cb-otel-agg-cache-'))
       dbPath   = join(tmpHome, 'agent-traces.db')
 
-      prevHome  = process.env['HOME']
-      prevCache = process.env['CODEBURN_CACHE_DIR']
       process.env['HOME']              = tmpHome
       process.env['CODEBURN_CACHE_DIR'] = tmpCache
 
@@ -116,10 +112,6 @@ describe.skipIf(!isSqliteAvailable())(
     afterEach(async () => {
       clearSessionCache()
       vi.unstubAllEnvs()
-      if (prevHome  === undefined) delete process.env['HOME']
-      else                          process.env['HOME'] = prevHome
-      if (prevCache === undefined) delete process.env['CODEBURN_CACHE_DIR']
-      else                          process.env['CODEBURN_CACHE_DIR'] = prevCache
       await rm(tmpHome,  { recursive: true, force: true })
       await rm(tmpCache, { recursive: true, force: true })
     })

tests/parser-claude-cwd.test.ts

@@ -7,30 +7,16 @@ import { parseAllSessions } from '../src/parser.js'
 import type { DateRange } from '../src/types.js'
 
 let tmpDir: string
-let originalConfigDir: string | undefined
-let originalDesktopSessionsDir: string | undefined
 
 beforeEach(async () => {
   tmpDir = await mkdtemp(join(tmpdir(), 'claude-cwd-test-'))
-  originalConfigDir = process.env['CLAUDE_CONFIG_DIR']
-  originalDesktopSessionsDir = process.env['CODEBURN_DESKTOP_SESSIONS_DIR']
   process.env['CLAUDE_CONFIG_DIR'] = tmpDir
   // Point desktop sessions at an empty subdir by default so real sessions
   // on the developer's machine do not bleed into the unit tests.
   process.env['CODEBURN_DESKTOP_SESSIONS_DIR'] = join(tmpDir, 'desktop-sessions')
 })
 
 afterEach(async () => {
-  if (originalConfigDir === undefined) {
-    delete process.env['CLAUDE_CONFIG_DIR']
-  } else {
-    process.env['CLAUDE_CONFIG_DIR'] = originalConfigDir
-  }
-  if (originalDesktopSessionsDir === undefined) {
-    delete process.env['CODEBURN_DESKTOP_SESSIONS_DIR']
-  } else {
-    process.env['CODEBURN_DESKTOP_SESSIONS_DIR'] = originalDesktopSessionsDir
-  }
   await rm(tmpDir, { recursive: true, force: true })
 })
 

tests/parser-gemini-cache.test.ts

@@ -10,24 +10,16 @@ import type { DateRange } from '../src/types.js'
 
 let home: string
 let cacheDir: string
-let previousHome: string | undefined
-let previousCacheDir: string | undefined
 
 beforeEach(async () => {
   home = await mkdtemp(join(tmpdir(), 'codeburn-gemini-home-'))
   cacheDir = await mkdtemp(join(tmpdir(), 'codeburn-gemini-cache-'))
-  previousHome = process.env['HOME']
-  previousCacheDir = process.env['CODEBURN_CACHE_DIR']
   process.env['HOME'] = home
   process.env['CODEBURN_CACHE_DIR'] = cacheDir
 })
 
 afterEach(async () => {
   clearSessionCache()
-  if (previousHome === undefined) delete process.env['HOME']
-  else process.env['HOME'] = previousHome
-  if (previousCacheDir === undefined) delete process.env['CODEBURN_CACHE_DIR']
-  else process.env['CODEBURN_CACHE_DIR'] = previousCacheDir
   await rm(home, { recursive: true, force: true })
   await rm(cacheDir, { recursive: true, force: true })
 })

tests/parser-large-session.test.ts

@@ -16,7 +16,6 @@ beforeEach(async () => {
 
 afterEach(async () => {
   clearSessionCache()
-  delete process.env['CLAUDE_CONFIG_DIR']
   await rm(home, { recursive: true, force: true })
 })
 

tests/parser-local-savings.test.ts

@@ -20,25 +20,18 @@ function makeRange(): DateRange {
 }
 
 let tmpDirs: string[] = []
-let originalConfigDir: string | undefined
 
 beforeAll(async () => {
   await loadPricing()
 })
 
 beforeEach(() => {
-  originalConfigDir = process.env['CLAUDE_CONFIG_DIR']
   setLocalModelSavings({})
   setModelAliases({})
 })
 
 afterEach(async () => {
   delete (Object.prototype as Record<string, unknown>).calls
-  if (originalConfigDir === undefined) {
-    delete process.env['CLAUDE_CONFIG_DIR']
-  } else {
-    process.env['CLAUDE_CONFIG_DIR'] = originalConfigDir
-  }
   clearSessionCache()
   while (tmpDirs.length > 0) {
     const d = tmpDirs.pop()

tests/parser-proxy-codex-only.test.ts

@@ -18,8 +18,6 @@ const CWD = '/Users/test/codexonlyproxied'
 let tmpDirs: string[] = []
 
 afterEach(async () => {
-  delete process.env['CODEX_HOME']
-  delete process.env['CLAUDE_CONFIG_DIR']
   while (tmpDirs.length > 0) {
     const d = tmpDirs.pop()
     if (d) await rm(d, { recursive: true, force: true })

tests/parser-proxy-merge.test.ts

@@ -19,8 +19,6 @@ const MERGE_CWD = '/Users/test/proxiedmerge'
 let tmpDirs: string[] = []
 
 afterEach(async () => {
-  delete process.env['CLAUDE_CONFIG_DIR']
-  delete process.env['CODEX_HOME']
   while (tmpDirs.length > 0) {
     const d = tmpDirs.pop()
     if (d) await rm(d, { recursive: true, force: true })

tests/parser-proxy-pricing.test.ts

@@ -127,14 +127,12 @@ const makeRange = (): DateRange => ({ start: RANGE_START, end: RANGE_END })
 const FIXTURE_CWD = '/private/var/eywa-proxy-fixture/acme'
 
 let tmpDirs: string[] = []
-let originalConfigDir: string | undefined
 
 beforeAll(async () => {
   await loadPricing()
 })
 
 beforeEach(() => {
-  originalConfigDir = process.env['CLAUDE_CONFIG_DIR']
   setProxyPaths([])
   setLocalModelSavings({})
   setModelAliases({})
@@ -143,8 +141,6 @@ beforeEach(() => {
 
 afterEach(async () => {
   setProxyPaths([])
-  if (originalConfigDir === undefined) delete process.env['CLAUDE_CONFIG_DIR']
-  else process.env['CLAUDE_CONFIG_DIR'] = originalConfigDir
   clearSessionCache()
   while (tmpDirs.length > 0) {
     const d = tmpDirs.pop()

tests/parser.test.ts

@@ -172,15 +172,11 @@ function totalOutput(projects: Awaited<ReturnType<typeof parseAllSessions>>): nu
 // ── Common env setup ──────────────────────────────────────────────────────
 let tmpHome: string
 let tmpCache: string
-let prevHome: string | undefined
-let prevCache: string | undefined
 
 beforeEach(async () => {
   tmpHome  = await mkdtemp(join(tmpdir(), 'cb-parser-test-home-'))
   tmpCache = await mkdtemp(join(tmpdir(), 'cb-parser-test-cache-'))
 
-  prevHome  = process.env['HOME']
-  prevCache = process.env['CODEBURN_CACHE_DIR']
   process.env['HOME']               = tmpHome
   process.env['CODEBURN_CACHE_DIR'] = tmpCache
 
@@ -194,11 +190,6 @@ afterEach(async () => {
   clearSessionCache()
   vi.unstubAllEnvs()
 
-  if (prevHome  === undefined) delete process.env['HOME']
-  else                          process.env['HOME'] = prevHome
-  if (prevCache === undefined) delete process.env['CODEBURN_CACHE_DIR']
-  else                          process.env['CODEBURN_CACHE_DIR'] = prevCache
-
   _synthSources = []
 
   await rm(tmpHome,  { recursive: true, force: true })

tests/plan-usage.test.ts

@@ -185,7 +185,6 @@ describe('getPlanUsage', () => {
 
   it('keeps the provider-specific parser filter for one active plan', async () => {
     const dir = await mkdtemp(join(tmpdir(), 'codeburn-plan-usage-test-'))
-    const previousHome = process.env['HOME']
     process.env['HOME'] = dir
 
     try {
@@ -217,18 +216,12 @@ describe('getPlanUsage', () => {
       expect(usages).toHaveLength(1)
       expect(usages[0]?.spentApiEquivalentUsd).toBe(80)
     } finally {
-      if (previousHome === undefined) {
-        delete process.env['HOME']
-      } else {
-        process.env['HOME'] = previousHome
-      }
       await rm(dir, { recursive: true, force: true })
     }
   })
 
   it('computes multiple active plan usages from one all-provider parse', async () => {
     const dir = await mkdtemp(join(tmpdir(), 'codeburn-plan-usage-test-'))
-    const previousHome = process.env['HOME']
     process.env['HOME'] = dir
 
     try {
@@ -344,11 +337,6 @@ describe('getPlanUsage', () => {
       expect(usages.map(usage => usage.plan.provider)).toEqual(['claude', 'codex'])
       expect(usages.map(usage => usage.spentApiEquivalentUsd)).toEqual([100, 50])
     } finally {
-      if (previousHome === undefined) {
-        delete process.env['HOME']
-      } else {
-        process.env['HOME'] = previousHome
-      }
       await rm(dir, { recursive: true, force: true })
     }
   })

tests/plans.test.ts

@@ -29,7 +29,6 @@ describe('plan presets', () => {
 describe('plan config persistence', () => {
   it('round-trips per-provider plans and clears one provider at a time', async () => {
     const dir = await mkdtemp(join(tmpdir(), 'codeburn-plan-test-'))
-    const previousHome = process.env['HOME']
     process.env['HOME'] = dir
 
     try {
@@ -74,18 +73,12 @@ describe('plan config persistence', () => {
       expect(await readPlan()).toBeUndefined()
       expect(await readPlans()).toEqual({})
     } finally {
-      if (previousHome === undefined) {
-        delete process.env['HOME']
-      } else {
-        process.env['HOME'] = previousHome
-      }
       await rm(dir, { recursive: true, force: true })
     }
   })
 
   it('reads legacy single-plan config as a provider-keyed plan map', async () => {
     const dir = await mkdtemp(join(tmpdir(), 'codeburn-plan-test-'))
-    const previousHome = process.env['HOME']
     process.env['HOME'] = dir
 
     try {
@@ -107,18 +100,12 @@ describe('plan config persistence', () => {
         resetDay: 3,
       })
     } finally {
-      if (previousHome === undefined) {
-        delete process.env['HOME']
-      } else {
-        process.env['HOME'] = previousHome
-      }
       await rm(dir, { recursive: true, force: true })
     }
   })
 
   it('drops a hand-edited all plan when provider-specific plans are present', async () => {
     const dir = await mkdtemp(join(tmpdir(), 'codeburn-plan-test-'))
-    const previousHome = process.env['HOME']
     process.env['HOME'] = dir
 
     try {
@@ -144,18 +131,12 @@ describe('plan config persistence', () => {
       expect(plans.claude).toMatchObject({ id: 'claude-max', provider: 'claude' })
       expect(await readPlan()).toMatchObject({ id: 'claude-max', provider: 'claude' })
     } finally {
-      if (previousHome === undefined) {
-        delete process.env['HOME']
-      } else {
-        process.env['HOME'] = previousHome
-      }
       await rm(dir, { recursive: true, force: true })
     }
   })
 
   it('does not allow an all-provider plan to overlap provider-specific plans', async () => {
     const dir = await mkdtemp(join(tmpdir(), 'codeburn-plan-test-'))
-    const previousHome = process.env['HOME']
     process.env['HOME'] = dir
 
     try {
@@ -191,11 +172,6 @@ describe('plan config persistence', () => {
       })
       expect((await readPlans()).claude).toBeUndefined()
     } finally {
-      if (previousHome === undefined) {
-        delete process.env['HOME']
-      } else {
-        process.env['HOME'] = previousHome
-      }
       await rm(dir, { recursive: true, force: true })
     }
   })