fix(ci): scope concurrency cancel-in-progress to PR events only#39
Merged
Conversation
test.yml + integration.yml shipped with `cancel-in-progress: true` and
`group: <name>-${{ github.ref }}`. Two consecutive pushes to main share
the same `github.ref` (refs/heads/main), so the second push CANCELS the
first — main runs that haven't finished get killed by the next merge.
Reshape to the same pattern shipped on the other SDK repos
(sdk-{java,python,typescript,go}#176/#194/#225/#167):
group: <name>-\${{ github.event.pull_request.number || github.sha }}
cancel-in-progress: \${{ github.event_name == 'pull_request' }}
PR rebases cancel orphans by PR#. Push-to-main runs each get a unique
SHA group so they never queue or cancel each other.
audit.yml + release.yml don't have PR triggers, so concurrency would be
cosmetic — left as-is.
Signed-off-by: Saurabh Jain <dev@getaxonflow.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctness fix: test.yml + integration.yml shipped with
cancel-in-progress: truekeyed ongithub.ref. Two consecutive pushes to main share the same ref, so the second push cancels the first — main runs get killed mid-flight. Reshapes to the same PR-only-cancel pattern as the other SDK repos. audit.yml + release.yml have no PR triggers — concurrency would be cosmetic, left alone.