Fix SwirlProgressIndicator (variant=bar) size heights to and add a new l size for both variants - #1756
Merged
Merged
Conversation
…dd l size RND-2844: the bar variant's xs and s sizes both rendered at 2px instead of 1px/2px, and there was no l size. Split the xs/s CSS rule, added xs=1px and l=8px, and extended SwirlProgressIndicatorSize with a proportional circle config entry for l so the type stays exhaustive.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-1756.westeurope.3.azurestaticapps.net |
fabio-carvalho88
self-requested a review
August 27, 2026 10:34
fabio-carvalho88
requested changes
Aug 27, 2026
marcomFlip
changed the title
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-1756.westeurope.3.azurestaticapps.net |
fabio-carvalho88
approved these changes
Sep 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swirl-progress-indicator'sbarvariant renderedxsandsat the same height (2px) and had nolsize. This updates the CSS to match the desired size mapping and adds the missinglsize.Before → after (bar height)
Since
sizeis shared with thecirclevariant, andcircleSizeConfigis aRecord<SwirlProgressIndicatorSize, ...>requiring every key, I added a proportionallentry forcircletoo (radius: 40, strokeWidth: 8— double themconfig, matching the existings→mstroke/diameter ratio). No spec called out circle geometry forl, so flagging this choice for review.What a reviewer should know
custom-elements.manifest.jsonandvscode-data.jsonare regenerated build artifacts (viastencil build) reflecting the newlsize in the type union — not hand-edited.lsize on bothbarandcirclevariants.patch).Test plan
stencil test --spec— all 508 tests pass (including newl-size cases)eslinton changed files — cleanxs/s/m/lbar heights measured via computed style match 1px/2px/4px/8px; unsetsizestill resolves to themdefault (4px)