Add interactive prop to swirl-tag - #1783
Open
matvlaovi-flip wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-1783.westeurope.3.azurestaticapps.net |
fabio-carvalho88
requested changes
Aug 28, 2026
| position: relative; | ||
| margin: 0; | ||
| font-family: inherit; | ||
| text-align: start; |
Collaborator
There was a problem hiding this comment.
nitpick: this seems redundant as the tag class is already inline-flex
|
|
||
| .tag--interactive { | ||
| position: relative; | ||
| margin: 0; |
Collaborator
There was a problem hiding this comment.
question: i've removed this and didn't saw any diff. however i wonder if we need it 🤔
| font-family: inherit; | ||
| text-align: start; | ||
| cursor: pointer; | ||
| appearance: none; |
Collaborator
There was a problem hiding this comment.
nitpick: this can be removed as we already control the appearance is css rules above (e.g. padding and background)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary