chore: address residual review nits (config readonly, url scheme, session doc)#18
Merged
Conversation
…sion doc) Three deferred nits from the pre-0.1.0 review, no behavior change beyond #2: 1. AdapterConfig fields are now `readonly`, matching EvidenceRule/EvidenceConfig and the code-style guide (resolved config is never mutated). 2. helioBaseUrl now requires an http(s) URL — URL.canParse alone accepted ftp:/file:/etc; the sideband only speaks HTTP. 3. mapSession JSDoc now documents that the channelId/'unknown' fallback can collapse distinct sessions onto one session_id (correlation-safe — fails closed on ambiguity — but operators wanting per-session scoping should supply sessionId/sessionKey).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tidies the three residual nits logged during the pre-
0.1.0review. No tag is cut.AdapterConfigfields →readonly— matchesEvidenceRule/EvidenceConfigand the code-style guide. Typecheck passing confirms the resolved config is never mutated.helioBaseUrlrequires an http(s) URL (only behavioral change) —URL.canParsealone acceptedftp:/file:/etc.; the sideband only speaks HTTP. New test coversftp:/file:rejected,https:accepted.mapSessionJSDoc now documents that thechannelId/'unknown'fallback can collapse distinct sessions onto onesession_id— correlation-safe (registry fails closed on ambiguity), but operators wanting per-session scoping should supplysessionId/sessionKey.Verification
pnpm verifygreen: 200 tests (was 198), 0 type errors, build ✓.