chore(security): patch hono CORS + undici TLS advisories#73
Merged
Conversation
Clears two high advisories that fail the `pnpm audit --audit-level=high` CI gate. Both are real upgrades, not audit ignores. - hono 4.12.14 → 4.12.26 (direct dep, packages/proxy): GHSA-88fw-hqm2-52qc, CORS middleware reflects any Origin with credentials on the wildcard default (patched ≥4.12.25). Helio's sideband rejects Origin headers and does not use the permissive CORS default, but the gate flags the version regardless. - undici override ≥7.28.0 (transitive, dashboard > jsdom > undici, dev/test only): GHSA-vmh5-mc38-953g, TLS cert-validation bypass in the SOCKS5 ProxyAgent (patched ≥7.28.0). A jsdom bump doesn't help — latest jsdom still declares `undici@^7.25.0` — so force the patched range via pnpm.overrides, matching the existing form-data override. Total audit findings 24 → 8; remaining high is the pre-existing esbuild/vite ignore tracked by #64. Proxy suite 1575 green, build + typecheck clean.
…iding The undici>=7.28.0 override broke the dashboard test suite: jsdom@29.0.1 deep-imports undici/lib/handler/wrap-handler.js, an internal path removed in undici 7.28, so every dashboard vitest worker failed with MODULE_NOT_FOUND. No undici version is both patched (>=7.28.0) and compatible with jsdom@29's internal layout (^7.25.0). undici here is dev/test-only (dashboard > jsdom test env, not shipped) and the advisory is a SOCKS5 ProxyAgent TLS path not exercised in tests, so revert the override and add GHSA-vmh5-mc38-953g to the dev-only ignore list — same posture as the existing vite dev-only ignore. The hono upgrade (a real, shipped fix) is unchanged. Verified: pnpm audit --audit-level=high exits 0; full pnpm test:js green (proxy 1575, dashboard 300); build + typecheck clean.
olivrg
added a commit
that referenced
this pull request
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clears two high advisories that fail the
pnpm audit --audit-level=highCI gate. Both are real upgrades, not audit ignores.undici@^7.25.0— so force the patched range via pnpm.overrides, matching the existing form-data override.Total audit findings 24 → 8; remaining high is the pre-existing esbuild/vite ignore tracked by #64. Proxy suite 1575 green, build + typecheck clean.
Type of Change
Packages Affected
packages/proxypackages/dashboardpackages/python-sdkdocs/examples/Checklist
anytypes or@ts-ignorewithout justificationpnpm secrets:scan,pnpm docs:check:ci,pnpm audit --audit-level=high,pnpm build,pnpm lint,pnpm format:check,pnpm typecheck,pnpm test)feat:,fix:,docs:)How to Test
pnpm install && pnpm audit --audit-level=high— exits 0 (was: 3 high, 1 ignored).pnpm --filter @gethelio/proxy build && pnpm -r typecheck && pnpm --filter @gethelio/proxy test— build + typecheck clean, 1575 tests pass.Refs #64 (same audit-gate-hygiene theme).
Additional Context