Skip to content

fix: various things - #385

Merged
iparaskev merged 4 commits into
mainfrom
fix/tray-external-monitor-position
Sep 15, 2026
Merged

iparaskev merged 4 commits into
mainfrom
fix/tray-external-monitor-position

Conversation

@iparaskev

@iparaskev iparaskev commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes

    • Improved macOS tray-based window positioning by detecting the monitor from the center of the tray icon.
    • Updated macOS window capture sizing for more consistent results on high-density displays.
    • Updated the settings window layout to keep content clear of the draggable top bar.
  • Updates

    • Updated the application version to 1.0.30.
    • Updated clipboard and application framework components.

@iparaskev
iparaskev requested a review from konsalex as a code owner September 15, 2026 16:54
@netlify

netlify Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for hoppdocs ready!

Name Link
🔨 Latest commit 022ea03
🔍 Latest deploy log https://app.netlify.com/projects/hoppdocs/deploys/6aa97f71cbc0c7000867262c
😎 Deploy Preview https://deploy-preview-385--hoppdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@iparaskev iparaskev changed the title Fix/tray external monitor position fix: various things Sep 15, 2026
@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f87ab129-83cc-410b-a295-741b945adb03

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea8ab7 and 022ea03.

📒 Files selected for processing (1)
  • core/src/capture/macos_stream.rs

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The PR updates Tauri dependencies and the application version. It changes tray monitor detection to use the tray center. It changes the settings drag region to a fixed top overlay. It applies a minimum scale of 2.0 to macOS window capture dimensions.

Changes

Desktop updates

Layer / File(s) Summary
Runtime and release version updates
tauri/src-tauri/Cargo.toml, tauri/src-tauri/tauri.conf.json
The Tauri dependencies and application version are updated.
Tray center monitor detection
tauri/src-tauri/src/lib.rs
center_window_on_tray calculates monitor offsets and warning output from the tray icon center.
Settings drag region layout
tauri/src/windows/settings/main.tsx
The drag region becomes a fixed top overlay. The settings content receives additional top padding.
macOS capture scaling
core/src/capture/macos_stream.rs
Initial and resize capture dimensions use backing or frame scale values with a minimum of 2.0.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 022ea

The reviewed desktop and capture changes have no verified merge-blocking risk.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title uses the vague phrase "various things" and does not identify the main changes, such as tray monitor detection or macOS capture scaling. Replace the title with a specific summary, such as "fix: correct tray monitor detection and macOS capture scaling".
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tray-external-monitor-position

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@iparaskev
iparaskev merged commit 1bf7ad5 into main Sep 15, 2026
21 of 24 checks passed
@iparaskev
iparaskev deleted the fix/tray-external-monitor-position branch September 15, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant