Skip to content

fix: resize overlay window when shared screen changes resolution - #387

Merged
iparaskev merged 1 commit into
mainfrom
properly_handle_screen_resize
Sep 16, 2026
Merged

iparaskev merged 1 commit into
mainfrom
properly_handle_screen_resize

Conversation

@iparaskev

@iparaskev iparaskev commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved remote-control overlay recovery after an active window is resized to match the monitor dimensions.
    • Automatically schedules overlay repair when its size no longer matches the resized window.

@netlify

netlify Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for hoppdocs ready!

Name Link
🔨 Latest commit 07616cf
🔍 Latest deploy log https://app.netlify.com/projects/hoppdocs/deploys/6aaae828dd12b7000880e266
😎 Deploy Preview https://deploy-preview-387--hoppdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b923a468-1f86-492d-ba35-2c3f4cfd1bcc

📥 Commits

Reviewing files that changed from the base of the PR and between 1bf7ad5 and 07616cf.

📒 Files selected for processing (2)
  • core/src/lib.rs
  • core/src/overlay_window.rs

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The resize handler now schedules overlay repair when the active window reaches the monitor size but the overlay remains at a different size.

Changes

Overlay resize repair

Layer / File(s) Summary
Resize detection and repair scheduling
core/src/overlay_window.rs, core/src/lib.rs
OverlayWindow::matches_size compares overlay dimensions with a PhysicalSize<u32>. The active-window resize handler schedules repair when the monitor size is reached, no repair is pending, and the overlay size differs.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 07616

The resize repair behavior has no verified merge-blocking risk in the supplied evidence.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: resizing the overlay window when the shared screen resolution changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch properly_handle_screen_resize

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@iparaskev
iparaskev merged commit c6bd7f1 into main Sep 16, 2026
20 of 21 checks passed
@iparaskev
iparaskev deleted the properly_handle_screen_resize branch September 16, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant