Repository navigation
feat: add generic OpenID Connect login #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mashpie
wants to merge
7
commits into
gethopp:main
Choose a base branch
from
uscreen:feat/oidc-sso
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5744181
feat(backend): add generic OpenID Connect login
mashpie 0fef3ad
feat(backend): add OIDC_SINGLE_TEAM to put all OIDC users into one team
mashpie dd33002
feat(web-app): add OpenID Connect login button
mashpie c6ff5b5
doc: document OpenID Connect login for self-hosting
mashpie a339a0a
fix(backend): verify OIDC ID token signatures and require https
mashpie a0aa2fe
fix(backend): bind OIDC single-team mode to a dedicated team
mashpie b73cad6
fix(backend): close two gaps in the OIDC callback
mashpie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package handlers | ||
|
|
||
| import ( | ||
| "net/http" | ||
|
|
||
| "github.com/labstack/echo/v4" | ||
| "github.com/markbates/goth" | ||
| ) | ||
|
|
||
| // OIDCConfigResponse describes the generic OpenID Connect login. | ||
| type OIDCConfigResponse struct { | ||
| Enabled bool `json:"enabled"` | ||
| DisplayName string `json:"display_name"` | ||
| } | ||
|
|
||
| // InstanceConfigResponse is the public, unauthenticated description of how this | ||
| // instance is configured. Clients use it to decide which flows to offer. | ||
| type InstanceConfigResponse struct { | ||
| OIDC OIDCConfigResponse `json:"oidc"` | ||
| } | ||
|
|
||
| // GetInstanceConfig returns the instance configuration relevant to clients. | ||
| func (h *AuthHandler) GetInstanceConfig(c echo.Context) error { | ||
| // Enabled only if the provider was actually registered: discovery can fail | ||
| // at startup even though OIDC is configured. | ||
| _, err := goth.GetProvider(oidcProviderName) | ||
|
|
||
| return c.JSON(http.StatusOK, InstanceConfigResponse{ | ||
| OIDC: OIDCConfigResponse{ | ||
| Enabled: err == nil, | ||
| DisplayName: h.Config.Auth.OIDC.DisplayName, | ||
| }, | ||
| }) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.