Skip to content

feat(ui): add configurable status-line rows - #1147

Draft
tautvydasLiekis wants to merge 1 commit into
masterfrom
feat/status-line-rows
Draft

tautvydasLiekis wants to merge 1 commit into
masterfrom
feat/status-line-rows

Conversation

@tautvydasLiekis

Copy link
Copy Markdown
Contributor

What was wrong

A crowded single status row hid useful fields, and changing customization could overwrite custom status-script settings. Ferment V2 state also lacked its own visible field on master.

Fix

Support one to three native rows (one by default), packing fields before shortening or hiding them. Preserve custom script configuration and output. Add a separate V2 field with a minimal presentation-only publisher; no plan-execution, naming or controller changes.

Validation

The script-preservation regression failed with the old assignment. Passed 392 focused tests, 13 TUI workflows, lint/typecheck and binary build. Independent review passed, including reruns of 294 focused tests and both customization workflows.

@tautvydasLiekis tautvydasLiekis added bug Something isn't working new feature Introduces a new feature labels Sep 7, 2026
@kimchi-review

kimchi-review Bot commented Sep 7, 2026

Copy link
Copy Markdown

Kimchi Code Review

Property Value
Commit 64a8715
Author @tautvydasLiekis
Files changed 14
Review status Completed
Comments 2 (2 info)
Duration 187s

Summary

📊 Review Score: 90/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 3/5 (1 = trivial, 5 = very complex)

🧪 Tests: yes — Comprehensive coverage: unit tests for multi-row fitting (renderFittedLines, StatusLineScript, config persistence, CustomizeStatusLineComponent row cycling), Ferment V2 status formatting/publishing, and end-to-end TUI tests for row customization and V2 lifecycle rendering.

📝 Found 2 issue(s). See inline comments for details.

What to expect

Kimchi will analyze the changes in this pull request and post:

  • A summary of the overall changes
  • Inline comments on specific lines with findings categorized by issue type

The review typically completes within a few minutes. This comment will be updated once the review is ready.

Interact with Kimchi
  • @getkimchi review — re-trigger a full review on the latest commit
  • @getkimchi summary — regenerate the PR summary
  • @getkimchi ignore — skip this PR (no review will be posted)
  • Reply to any inline comment to ask follow-up questions or request clarification
Configuration

Reviews are configured by your organization admin.
Review instructions, excluded directories, and severity thresholds can be adjusted per repository in the Kimchi dashboard.


Powered by Kimchi — AI-powered code review by CAST AI

@kimchi-review kimchi-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Review Score: 90/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 3/5 (1 = trivial, 5 = very complex)

🧪 Tests: yes — Comprehensive coverage: unit tests for multi-row fitting (renderFittedLines, StatusLineScript, config persistence, CustomizeStatusLineComponent row cycling), Ferment V2 status formatting/publishing, and end-to-end TUI tests for row customization and V2 lifecycle rendering.

📝 Found 2 issue(s). See inline comments for details.

Comment thread src/components/status-line.ts
Comment thread src/components/status-line.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working new feature Introduces a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant