feat(ui): add configurable status-line rows - #1147
tautvydasLiekis wants to merge 1 commit into
Conversation
Kimchi Code Review
Summary📊 Review Score: 90/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: yes — Comprehensive coverage: unit tests for multi-row fitting ( 📝 Found 2 issue(s). See inline comments for details. What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
There was a problem hiding this comment.
📊 Review Score: 90/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 3/5 (1 = trivial, 5 = very complex)
🧪 Tests: yes — Comprehensive coverage: unit tests for multi-row fitting (renderFittedLines, StatusLineScript, config persistence, CustomizeStatusLineComponent row cycling), Ferment V2 status formatting/publishing, and end-to-end TUI tests for row customization and V2 lifecycle rendering.
📝 Found 2 issue(s). See inline comments for details.
What was wrong
A crowded single status row hid useful fields, and changing customization could overwrite custom status-script settings. Ferment V2 state also lacked its own visible field on master.
Fix
Support one to three native rows (one by default), packing fields before shortening or hiding them. Preserve custom script configuration and output. Add a separate V2 field with a minimal presentation-only publisher; no plan-execution, naming or controller changes.
Validation
The script-preservation regression failed with the old assignment. Passed 392 focused tests, 13 TUI workflows, lint/typecheck and binary build. Independent review passed, including reruns of 294 focused tests and both customization workflows.