fix(invoices): skip MarkOverdueService when invoice is already overdue#5497
Open
tiagolupepic wants to merge 1 commit into
Open
fix(invoices): skip MarkOverdueService when invoice is already overdue#5497tiagolupepic wants to merge 1 commit into
tiagolupepic wants to merge 1 commit into
Conversation
Adds a guard clause to Invoices::Payments::MarkOverdueService that returns an 'invoice_already_overdue' not_allowed_failure when the invoice's payment_overdue flag is already true, preventing redundant updates and duplicate invoice.payment_overdue webhook deliveries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commits add an extra guard clause to MarkOverdueService.
We're adding an extra guard clause on MarkOverdueService to avoid mark the invoice
payment_overdue to true when is already done.
Having this, we're preventing redundant updates and duplicate invoice.payment_overdue webhook deliveries.