fix(coupon): Coupon code column missing NOT NULL constraint in database#5500
Merged
Conversation
groyoh
requested changes
May 13, 2026
Contributor
groyoh
left a comment
groyoh
left a comment
There was a problem hiding this comment.
Could you please also regression tests to ensure sending nil code will be failing both on the API and GraphQL ?
groyoh
approved these changes
May 15, 2026
Contributor
groyoh
left a comment
groyoh
left a comment
There was a problem hiding this comment.
I believe we're still missing a non-regression test on the graphQL/api side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The coupons table allows NULL values for the code column, meaning a coupon can be created via the API without providing a code. This is inconsistent with our public API documentation, which marks code as a required field and every other model with a code column (add_on, billable_metric, plan, billing_entity, tax, pricing_unit, charge, etc.) which all have NOT NULL at the DB level.
Description
Add presence: true to the model and required: true in GraphQL, stops new NULLs from being created.
Included a data migration to assign auto-generated codes to any existing NULL-code coupons and the NOT NULL clause on the code.