Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/services/charges/validators/base_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ def validate_presentation_group_keys
raw_keys = properties["presentation_group_keys"]
return if raw_keys.blank?

values = []
valid_presentation_group_keys = raw_keys.is_a?(Array) && raw_keys.all? do |key|
next false unless key.is_a?(Hash)

Expand All @@ -80,6 +81,8 @@ def validate_presentation_group_keys
end
end

values << key[:value] if value_valid

keys_valid && value_key_present && value_valid && options_key_valid
end

Expand All @@ -93,6 +96,10 @@ def validate_presentation_group_keys
if raw_keys.size > 2
add_error(field: "presentation_group_keys", error_code: "too_many_keys")
end

if values.size != values.uniq.size
add_error(field: "presentation_group_keys", error_code: "value_is_duplicated")
end
end
end
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,17 @@
end
end

context "when presentation_group_keys has duplicated values" do
let(:presentation_group_keys) { [{"value" => "country"}, {"value" => "country"}] }

it "is invalid" do
expect(validation_service).not_to be_valid
expect(validation_service.result.error).to be_a(BaseService::ValidationFailure)
expect(validation_service.result.error.messages.keys).to include(:presentation_group_keys)
expect(validation_service.result.error.messages[:presentation_group_keys]).to include("value_is_duplicated")
end
end

context "when presentation_group_keys has options" do
let(:presentation_group_keys) do
[
Expand Down
Loading