feat(payment-gated-subs): Cover activation of incomplete subscriptions coming from upgrades#5580
Closed
osmarluz wants to merge 3 commits into
Closed
Conversation
…e-subscriptions-from-upgrade
Contributor
Author
|
Replaced by #5586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Builds on #5533, which gated subscription upgrades only from the from-pending path. A gated upgrade actually completes from the incomplete state, once payment resolves — this PR covers that path.
Description
Subscriptions::ActivateService#activate_from_incompletenow routes throughactivate_for_upgradewhen the subscription has aprevious_subscription, mirroring the pending path.activate_for_upgradedistinguishes from-incomplete: skips re-emitting fixed-charge events (already done at gating) and bills only the previous subscription with:upgrading(the new subscription was billed withskip_chargeswhen gated).bill_upgrade_subscriptionsinstead of through an instance variable.