Skip to content

feat(charge): Add standalone charge CRUD endpoints#30

Merged
rsempe merged 1 commit into
mainfrom
charge-endpoints
May 12, 2026
Merged

feat(charge): Add standalone charge CRUD endpoints#30
rsempe merged 1 commit into
mainfrom
charge-endpoints

Conversation

@rsempe
Copy link
Copy Markdown
Contributor

@rsempe rsempe commented Feb 23, 2026

Add charge, fixed charge, and charge filter CRUD endpoints for both plans and subscriptions to the Rust client.

@sarkissianraffi
Copy link
Copy Markdown

sarkissianraffi commented Apr 17, 2026

Hey @rsempe — I rebased this branch onto current main (just the 429-retry commit on top of the fork point). No source conflicts; Git auto-merged the lago-client/Cargo.toml change because your dep line and main's version bump touched different lines. Cargo.lock updated for the newer deps.

Rebased branch pushed as revive-charge-endpoints (didn't force-push over your branch). Local verification:

  • cargo build --workspace --all-targets
  • cargo clippy -p lago-types -p lago-client --lib --tests -- -D warnings
  • cargo test --workspace --lib ✅ (23 tests pass)

Feel free to:

  • Fast-forward your branch to it: git fetch origin && git reset --hard origin/revive-charge-endpoints && git push --force-with-lease, or
  • Cherry-pick / ignore — your call.

Context: I needed update_plan_charge to stop losing charge lago_ids on plan updates and noticed this PR already solves it. Happy to help push it over the line.

@rsempe rsempe force-pushed the charge-endpoints branch 3 times, most recently from d35c0d7 to 38a7e81 Compare May 11, 2026 19:27
Add charge, fixed charge, and charge filter CRUD endpoints
for both plans and subscriptions to the Rust client.
@rsempe rsempe force-pushed the charge-endpoints branch from 38a7e81 to eaa8145 Compare May 11, 2026 19:31
@sarkissianraffi sarkissianraffi requested a review from jdenquin May 12, 2026 07:32
Comment thread lago-types/src/models/plan.rs
Copy link
Copy Markdown

@annvelents annvelents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@rsempe rsempe merged commit 89454eb into main May 12, 2026
1 check passed
@rsempe rsempe deleted the charge-endpoints branch May 12, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants