Wire BanditURLOverrides through to MutableURLTest by myleshorton · Pull Request #333 · getlantern/radiance

myleshorton · 2026-02-20T17:11:23Z

Summary

Passes BanditURLOverrides from config response through to sing-box MutableURLTestOutboundOptions.URLOverrides
Updates urlTestOutbound() and appendGroupOutbounds() to accept and forward urlOverrides map[string]string
Lantern server group gets bandit overrides; user group and autoAll pass nil
Updates go.mod to reference common and lantern-box bandit-url-overrides branches

Test plan

go vet ./vpn/... passes
Existing TestConnection and TestUpdateServers still pass
Verify MutableURLTest uses per-proxy callback URLs when overrides are present

🤖 Generated with Claude Code

Pass per-proxy callback URLs from config response through to sing-box MutableURLTest URLOverrides, enabling per-ISP bandit proxy assignment on the client side. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

This PR threads BanditURLOverrides from the loaded config through to Lantern’s MutableURLTestOutboundOptions.URLOverrides, enabling per-proxy URL test callback overrides to reach the sing-box mutable URL test implementation.

Changes:

Extend urlTestOutbound() and appendGroupOutbounds() to accept urlOverrides map[string]string and forward it into MutableURLTestOutboundOptions.URLOverrides.
Pass cfg.BanditURLOverrides into the Lantern server group’s URL test outbound; keep User/All URL test outbounds using nil.
Update module dependencies (go.mod/go.sum) to versions/branches that include the new options surface.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
vpn/vpn.go	Updates pre-start URL test outbound construction to the new `urlTestOutbound` signature (currently passing `nil` overrides).
vpn/tunnel_test.go	Updates tests to call `urlTestOutbound` with the new signature.
vpn/boxoptions.go	Wires `BanditURLOverrides` into the Lantern group’s MutableURLTest outbound and adds `URLOverrides` to the outbound options.
go.mod	Bumps `common`/`lantern-box` (and other deps) to versions needed for the new override option surface.
go.sum	Corresponding checksum updates after dependency changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-20T17:18:38Z

vpn/vpn.go

 		tags = append(tags, ob.Tag)
 	}
-	outbounds = append(outbounds, urlTestOutbound("preTest", tags))
+	outbounds = append(outbounds, urlTestOutbound("preTest", tags, nil))


preTest() loads the config into cfg, but still calls urlTestOutbound("preTest", tags, nil), so BanditURLOverrides from the config are ignored during pre-start URL tests. If overrides are meant to affect URL testing behavior, they should be forwarded here as well (e.g., pass cfg.BanditURLOverrides).

Copilot · 2026-02-20T17:18:39Z

vpn/boxoptions.go

 	slog.Debug("Merged config options", "tags", lanternTags)

-	appendGroupOutbounds(&opts, servers.SGLantern, autoLanternTag, lanternTags)
+	appendGroupOutbounds(&opts, servers.SGLantern, autoLanternTag, lanternTags, cfg.BanditURLOverrides)


The PR introduces URLOverrides wiring for MutableURLTest, but the existing buildOptions tests only validate Outbounds membership. Consider adding an assertion that the autoLanternTag MutableURLTest outbound includes the expected URLOverrides when cfg.BanditURLOverrides is set, to prevent regressions.

Copilot · 2026-02-20T17:18:39Z

go.mod

 	github.com/sagernet/sing v0.7.18
-	github.com/sagernet/sing-box v1.12.13
-	github.com/sagernet/sing-dns v0.4.6
+	github.com/sagernet/sing-box v1.12.22


github.com/sagernet/sing-box is still replaced with github.com/getlantern/sing-box-minimal v1.12.19-lantern (see replace directive at the top of this file), so bumping the required sing-box version to v1.12.22 doesn’t actually change the code you build against and can be confusing. Either align the replace target/version with the intended upgrade, or keep the required version consistent with what’s actually used via replace.

Suggested change

github.com/sagernet/sing-box v1.12.22

github.com/sagernet/sing-box v1.12.19

Forward cfg.BanditURLOverrides into the preTest urlTestOutbound so bandit callback URLs are used during pre-start URL testing, not just during normal operation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Verify that URLOverrides from config.BanditURLOverrides are correctly forwarded into the auto-lantern MutableURLTestOutboundOptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Periodically reports per-outbound throughput to the bandit system so it can optimize for actual download speed, not just connectivity. Interval and body size are randomized to avoid creating a fingerprintable signal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…sts" This reverts commit 7b3bd80.

garmr-ulfr · 2026-02-24T20:04:20Z

@myleshorton are the BanditURLOverrides specific to each proxy, meaning each new config will contain new override URLs? If that's the case, do they need to be? The existing overrides will become invalid once we receive a new config.

myleshorton · 2026-02-24T20:11:27Z

@myleshorton are the BanditURLOverrides specific to each proxy, meaning each new config will contain new override URLs? If that's the case, do they need to be? The existing overrides will become invalid once we receive a new config.

Basically each config response is a test for each "arm" of the multi-armed bandit, so each URL has a token for that test that allows the server to identify it when the client makes the callback. So each proxy gets its own token essentially.

garmr-ulfr · 2026-02-24T20:23:15Z

Gotcha. Then they'll become invalid as soon as we receive a new config... We could add a field, (URLTester??), to MutableURLTestOptions to specify which tester implementation to use. Then we can implement a bandit-based tester that supports updating tokens dynamically when the config changes.

myleshorton · 2026-02-24T21:16:52Z

I don't quite understand the problem sorry. What's bad about them becoming invalid?

garmr-ulfr · 2026-02-24T21:25:10Z

When a new config is received, won't it have new override URLs that are specific to the new proxies?

myleshorton · 2026-02-24T21:26:22Z

Yeah, but that's what we want -- that means the server wants to test those.

myleshorton · 2026-02-24T21:26:51Z

This might be helpful:

https://github.com/getlantern/lantern-cloud/blob/bandit-url-overrides/docs/src/concepts/bandit.md

garmr-ulfr · 2026-02-24T21:38:52Z

Yeah, but that's what we want -- that means the server wants to test those.

Right, so when we get a new config while the VPN is connected, we update the outbounds/endpoints and just add the new tags to the MutableURLTest outbounds. Since they're not recreated, they won't have the new override URLs.

myleshorton · 2026-02-24T22:14:26Z

Oh sorry I misunderstood! OK, I should be able to fix that.

Persist URLOverrides in servers.Options so they survive file-watcher reloads, and call SetURLOverrides in updateGroup so new proxies from a config refresh get their bandit callback URLs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

myleshorton · 2026-02-25T22:44:39Z

OK that last commit implements a fairly straightforward solution I think?

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-25T22:56:32Z

vpn/tunnel.go

+	if err := t.mutGrpMgr.SetURLOverrides(autoTag, newOpts.URLOverrides); err != nil {
+		slog.Warn("Failed to set URL overrides", "group", autoTag, "error", err)
+	}


newOpts.URLOverrides is used here after newOpts = removeDuplicates(...), but removeDuplicates currently rebuilds a fresh servers.Options without copying URLOverrides. That means overrides will be dropped and this call will usually set nil/empty overrides (effectively clearing them). Preserve the original overrides (e.g., stash before de-dupe and apply after) or update removeDuplicates to carry URLOverrides through.

Copilot · 2026-02-25T22:56:32Z

servers/manager.go

 type Options struct {
-	Outbounds []option.Outbound           `json:"outbounds,omitempty"`
-	Endpoints []option.Endpoint           `json:"endpoints,omitempty"`
-	Locations map[string]C.ServerLocation `json:"locations,omitempty"`
+	Outbounds    []option.Outbound           `json:"outbounds,omitempty"`
+	Endpoints    []option.Endpoint           `json:"endpoints,omitempty"`
+	Locations    map[string]C.ServerLocation `json:"locations,omitempty"`
+	URLOverrides map[string]string           `json:"url_overrides,omitempty"`


URLOverrides is added to servers.Options but Manager doesn't currently copy/persist it anywhere (e.g., setServers() rebuilds opts without copying it, Servers() doesn't clone it, and merge() doesn't merge it). As a result, any overrides passed into SetServers will be silently dropped and never reach the tunnel. Update the manager to store/clone/merge URLOverrides alongside the other fields (and ensure it round-trips via saveServers/loadServers).

- Fix URLOverrides lost through removeDuplicates: stash overrides before dedup and pass the stashed value to SetURLOverrides - Persist URLOverrides through servers.Manager: clone in setServers and Servers so overrides survive save/load round-trips - go.sum updated by go mod tidy Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Wire BanditURLOverrides through to MutableURLTest

4e99a20

Pass per-proxy callback URLs from config response through to sing-box MutableURLTest URLOverrides, enabling per-ISP bandit proxy assignment on the client side. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings February 20, 2026 17:11

Copilot started reviewing on behalf of myleshorton February 20, 2026 17:11 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

myleshorton and others added 5 commits February 20, 2026 11:06

Pass BanditURLOverrides to preTest URL tests

bba0b2e

Forward cfg.BanditURLOverrides into the preTest urlTestOutbound so bandit callback URLs are used during pre-start URL testing, not just during normal operation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add test for BanditURLOverrides wiring in buildOptions

823eb1d

Verify that URLOverrides from config.BanditURLOverrides are correctly forwarded into the auto-lantern MutableURLTestOutboundOptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Revert "Add throughput reporter with jittered timing and padded reque…

adf8ba5

…sts" This reverts commit 7b3bd80.

Updated to mainline of lantern-box

94f125c

myleshorton requested a review from garmr-ulfr February 24, 2026 19:46

myleshorton requested a review from Copilot February 25, 2026 22:47

Copilot started reviewing on behalf of myleshorton February 25, 2026 22:47 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

myleshorton marked this pull request as draft February 26, 2026 00:11

	github.com/sagernet/sing-box v1.12.22
	github.com/sagernet/sing-box v1.12.19

Conversation

myleshorton commented Feb 20, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

garmr-ulfr commented Feb 24, 2026

Uh oh!

myleshorton commented Feb 24, 2026

Uh oh!

garmr-ulfr commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

myleshorton commented Feb 24, 2026

Uh oh!

garmr-ulfr commented Feb 24, 2026

Uh oh!

myleshorton commented Feb 24, 2026

Uh oh!

myleshorton commented Feb 24, 2026

Uh oh!

garmr-ulfr commented Feb 24, 2026

Uh oh!

myleshorton commented Feb 24, 2026

Uh oh!

myleshorton commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

garmr-ulfr commented Feb 24, 2026 •

edited

Loading