feat: route server manager requests through bypass proxy#342
Merged
myleshorton merged 4 commits intomainfrom Feb 25, 2026
Merged
feat: route server manager requests through bypass proxy#342myleshorton merged 4 commits intomainfrom
myleshorton merged 4 commits intomainfrom
Conversation
The server manager uses HTTP to communicate with private servers. When the VPN is active, these requests would be routed through the tunnel, creating a loop. Use bypass.DialContext to route them outside the tunnel. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request modifies the server manager's HTTP client to route requests through the bypass proxy instead of using a plain net.Dialer. This prevents routing loops when the VPN is active and the server manager needs to reach private server endpoints.
Changes:
- Modified
retryableHTTPClient()to usebypass.DialContextfor the HTTP transport's DialContext - Removed explicit timeout and keepalive configuration from the net.Dialer (now handled by bypass implementation)
- Updated comments to reflect the use of bypass proxy for routing outside the VPN tunnel
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Configure the net.Dialer in bypass.DialContext with 30s timeout and 30s keepalive to match the settings previously used by callers, rather than relying on OS defaults. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Picks up shuffled front vetting and CI fixes from fronted PR #68. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pass bypass.DialContext to fronted via WithDialer so that TLS handshakes to CDN fronts stay outside the VPN tunnel. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
YOLOing this since it's pretty straightforward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bypass.DialContextin the server manager's HTTP transport instead of a plainnet.Dialer, so requests to private servers are routed outside the VPN tunnelbypass.DialContextto fronted viaWithDialerso that TLS handshakes to CDN fronts also stay outside the VPN tunnel, preventing routing loopsgithub.com/getlantern/frontedto latest main, which adds theWithDialeroption and fixes CI test timeouts by shuffling fronts before vettingTest plan
go build ./...compilesgo test ./servers/passesgo test ./bypass/passes🤖 Generated with Claude Code