Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates authentication state management by introducing a dedicated settings key for JWT tokens and wiring JWT persistence/usage into login, OAuth callback, and logout flows.
Changes:
- Add
JwtTokenKeyto settings constants for persisting JWT tokens. - Persist JWT tokens into settings from login responses and OAuth callback.
- Include the JWT token in the logout request.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
common/settings/settings.go |
Adds a new settings key for persisting the JWT token. |
api/user.go |
Stores JWT tokens during auth flows and sends JWT token during logout. |
Comments suppressed due to low confidence (1)
api/user.go:326
a.Reset()clears legacy settings but does not clearsettings.JwtTokenKey, so the JWT can remain on disk after logout and be reused unintentionally. Clear the JWT token on logout (or updateAPIClient.Reset()to also resetJwtTokenKey) after a successful SignOut.
a.Reset()
a.salt = nil
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
myleshorton
approved these changes
Feb 26, 2026
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the handling of JWT tokens in user authentication workflows by introducing a new
JwtTokenKeysetting and updating relevant logic to ensure JWT tokens are properly stored and managed during login, OAuth callback, and logout operations.JWT Token Management Improvements:
JwtTokenKeytocommon/settings/settings.gofor storing JWT tokens in settings.setDatamethod inapi/user.goto save JWT tokens from login responses and log errors if saving fails.OAuthLoginCallbackmethod to store the OAuth JWT token in settings after successful authentication.Logout Process Enhancement:
Logoutmethod to include the JWT token in the logout request and log the logout request for debugging purposes.