Use the jsoncons non-throwing versions of decode for cbor and ubjson#550
Conversation
Summary of ChangesHello @Ian-Flury, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the CBOR and UBJSON decoding logic to utilize non-throwing versions of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully replaces the exception-throwing decode_* functions with their non-throwing try_decode_* counterparts for both CBOR and UBJSON deserialization. This is a great improvement for error handling robustness. The corresponding tests have been updated to verify the new behavior, including checks for the new error messages and ensuring no exceptions are thrown. I've included a couple of minor suggestions to improve test code readability.
cae42c0 to
d640686
Compare
jsoncons::decode_*in favor ofjsoncons::try_decode_*.