Skip to content

Use unique cursor names in postgres #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuzicheng1987 merged 1 commit into from
Dec 30, 2025
Merged

Use unique cursor names in postgres #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/sqlgen/internal/random.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
#ifndef SQLGEN_INTERNAL_RANDOM_HPP
#define SQLGEN_INTERNAL_RANDOM_HPP

#include <random>
#include <string>

Expand All @@ -11,3 +14,6 @@ inline std::string random() {
}

} // namespace sqlgen::internal

#endif // SQLGEN_INTERNAL_RANDOM_HPP

4 changes: 2 additions & 2 deletions include/sqlgen/postgres/Iterator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

#include "../Ref.hpp"
#include "../Result.hpp"
#include "../internal/random.hpp"
#include "../sqlgen_api.hpp"
#include "PostgresV2Connection.hpp"
#include "PostgresV2Result.hpp"
Expand Down Expand Up @@ -43,8 +44,7 @@ class SQLGEN_API Iterator {

private:
static std::string make_cursor_name() {
// TODO: Create unique cursor names.
return "sqlgen_cursor";
return "sqlgen_cursor_" + internal::random();
}

/// Shuts the iterator down.
Expand Down
Loading