fix(cli): include psycopg binary in postgres extra so driver works without system libpq#633
Open
Aaryan-549 wants to merge 1 commit intogetnao:mainfrom
Open
fix(cli): include psycopg binary in postgres extra so driver works without system libpq#633Aaryan-549 wants to merge 1 commit intogetnao:mainfrom
Aaryan-549 wants to merge 1 commit intogetnao:mainfrom
Conversation
…thout system libpq
Contributor
🚀 Preview Deployment
Preview will be automatically removed when this PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #589
PostgreSQL connections regressed in v0.1.0 because extras split in PR #477 shipped
ibis-framework[postgres]alone. Latest ibis pullsplain
psycopg(psycopg3), which is pure-Python and requires systemlibpqat runtime — fine on dev machines withlibpq-dev, broken onWindows, WSL, and most on-prem Linux installs. Import fails with:
which surfaces in nao as
MissingDependencyErrorfromrequire_database_backend("postgres"). Addingpsycopg[binary]to thepostgres(and
redshift, which reuses the backend) extra bundles a prebuilt libpq wheel sopip install 'nao-core[postgres]'works out of the box.Reproduced both before and after: pre-fix
PostgresConfig.check_connectionreturns False andexecute_sqlraises; post-fix both succeedand return correct rows for SELECT / aggregation / GROUP BY against a Postgres 16 container.
Changes:
cli/pyproject.toml: addpsycopg[binary]>=3.2.0topostgresandredshiftextrascli/uv.lock: regenerated