wordpress_compiler: fix regex and plugin category #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The linting errors are unrelated to this PR. Edit: #460 fixes these. |
Kwpolska
approved these changes
Aug 30, 2025
Contributor
Author
|
@Kwpolska thanks again! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex fix is necessary due to mrabarnett/mrab-regex#584.
I've tried to understand what
(\s|\S|\Z)should actually (other than matching a letter of anything or the end of the input, i.e. basically anything), and the conclusion seems to be that it's completely unnecessary. I also looked at the WordPress sources and found WordPress/WordPress@d04cd41, which basically does the same replacement as in this PR (namely, get rid of the bracket).