fix(timeline): size pills and clips in px, not in fractions of the timeline

src/components/ai-edition/v4/EditorShellV4.module.css

@@ -1330,6 +1330,11 @@
 	position: absolute;
 	top: 1px;
 	height: 22px;
+	/* The ONLY floor on a pill's width, and it is in px so it is the same hairline
+	   at every zoom: the box's width is the effect's duration, full stop. A `%`
+	   minimum is a duration in disguise (the old 1.5% drew everything shorter than
+	   27 s as 27 s on a 30-minute timeline). */
+	min-width: 1px;
 	display: inline-flex;
 	align-items: center;
 	gap: 5px;
@@ -1352,6 +1357,27 @@
 .lanePillSel {
 	box-shadow: 0 0 0 3px var(--accent-ring);
 }
+/* Narrower than its own chrome (PILL_HANDLES_MIN_PX): the handles mount OUTSIDE
+   the box instead of inside it, so overflow must not clip them away — there is
+   no content to clip at this width anyway (see pillAffordance/roomForLabel).
+   ::after widens the move target to reach the handles (PILL_MOVE_GAP_PX on each
+   side), which is what keeps a 1px pill grabbable without inflating the bar the
+   user is reading a duration off. */
+.lanePillCompact {
+	overflow: visible;
+	padding: 0;
+}
+.lanePillCompact::after {
+	content: "";
+	position: absolute;
+	inset: 0 -4px;
+}
+/* An outside handle sits on bare lane background, where a transparent grab strip
+   is undiscoverable — on hover it shows itself as a bar flanking the pill. */
+.lanePillCompact:hover .lanePillHandle {
+	background: color-mix(in oklch, currentColor 35%, transparent);
+	border-radius: 2px;
+}
 .lanePillLabel {
 	overflow: hidden;
 	text-overflow: ellipsis;
@@ -1378,8 +1404,14 @@
 }
 .tlClips {
 	position: relative;
-	display: flex;
-	gap: 6px;
+	/* NOT a flex row. Clips are absolutely positioned by percentage of the
+	   timeline, like the pills, the ruler and the playhead above them.
+	   A flex row's `gap` is a fixed pixel amount inserted into a proportional
+	   layout: each junction pushed what followed 6px right while every clip
+	   shrank proportionally to pay for the gaps, so a clip's left edge landed off
+	   its true start time — measured at +2px and +6px for clips 2 and 3 of a
+	   three-clip timeline, which is 5 s and 15 s of a 30-minute recording when
+	   zoomed out, and a fraction of a second when zoomed in. See .tlClip. */
 	height: 66px;
 	width: 100%;
 	padding: 0;
@@ -1398,9 +1430,19 @@
 	pointer-events: none;
 }
 .tlClip {
-	position: relative;
-	flex: 1 0 0;
-	min-width: 0;
+	/* left/width come from V4Timeline, in percent of the timeline. The 6px gutter
+	   that used to be a flex `gap` is now taken off each clip's own width, so it
+	   separates the cards without ever moving the next one: a clip's LEFT edge is
+	   its true start time at every zoom and every clip count.
+	   ponytail: the right edge therefore reads 6px short. Constant, non-cumulative
+	   and below the width of the border it sits next to; draw the separator inside
+	   the box (inset shadow, square-butted cards) if that ever needs to be exact. */
+	position: absolute;
+	top: 0;
+	bottom: 0;
+	/* px, like .lanePill's: the gutter is subtracted from the clip's width, so a
+	   clip narrower than 6px would otherwise compute to nothing. */
+	min-width: 1px;
 	border-radius: 11px;
 	border: 1.5px solid var(--border);
 	background: var(--surface-1);

src/components/ai-edition/v4/V4Timeline.geometry.test.tsx

@@ -0,0 +1,229 @@
+import "@testing-library/jest-dom";
+import { fireEvent, render, screen } from "@testing-library/react";
+import { beforeAll, describe, expect, it, vi } from "vitest";
+
+// The regression under test is geometric, so the environment has to have a size:
+// jsdom reports 0 for every box, which would leave `pxPerSec` at 0 (the
+// "unmeasured" case) and hide exactly the thing being checked.
+const VIEWPORT_PX = 900;
+const TOTAL_SEC = 1800; // a 30-minute recording, as in the report
+
+vi.mock("@/contexts/I18nContext", () => ({
+	useScopedT: () => (key: string) => key,
+}));
+vi.mock("sonner", () => ({ toast: { error: vi.fn(), info: vi.fn(), success: vi.fn() } }));
+
+import type { useTimeline } from "@/lib/ai-edition/store/useTimeline";
+import { V4Timeline } from "./V4Timeline";
+
+beforeAll(() => {
+	globalThis.ResizeObserver = class {
+		// jsdom has none, and the width it would report is stubbed below anyway.
+		observe() {
+			/* noop */
+		}
+		unobserve() {
+			/* noop */
+		}
+		disconnect() {
+			/* noop */
+		}
+	} as unknown as typeof ResizeObserver;
+	Object.defineProperty(HTMLElement.prototype, "clientWidth", {
+		configurable: true,
+		get: () => VIEWPORT_PX,
+	});
+	Object.defineProperty(HTMLElement.prototype, "getBoundingClientRect", {
+		configurable: true,
+		value: () => ({
+			x: 0,
+			y: 0,
+			left: 0,
+			top: 0,
+			right: VIEWPORT_PX,
+			bottom: 100,
+			width: VIEWPORT_PX,
+			height: 100,
+			toJSON() {
+				/* unused by the component */
+			},
+		}),
+	});
+});
+
+function clip(startSec: number, endSec: number) {
+	return {
+		id: `c@${startSec}`,
+		assetId: "a1",
+		timelineStartSec: startSec,
+		timelineEndSec: endSec,
+		sourceStartSec: 0,
+		sourceEndSec: endSec - startSec,
+	};
+}
+
+/** By default one 30-minute clip carrying a single one-second annotation. */
+function renderTimeline(
+	clips = [clip(0, TOTAL_SEC)],
+	annotation = { id: "ann1", startMs: 10_000, endMs: 11_000 },
+) {
+	const tl = {
+		clips,
+		assets: [{ id: "a1", label: "rec", durationSec: TOTAL_SEC }],
+		annotationRegions: [annotation],
+		speedRegions: [],
+		cameraFullscreenRegions: [],
+		zoomRegions: [],
+		trimRanges: [],
+		selection: null,
+		multiSelection: [],
+		clipSelection: null,
+		clearSelection: vi.fn(),
+		selectRegion: vi.fn(),
+		selectClip: vi.fn(),
+		updateAnnotationSpan: vi.fn(async () => {
+			/* the drag only awaits it */
+		}),
+	};
+	render(
+		<V4Timeline
+			// Only the members the lanes and the clip row read are mocked; the prop
+			// stays typed as the real API rather than widened to `any` (AGENTS.md).
+			tl={tl as unknown as ReturnType<typeof useTimeline>}
+			setCurrentTime={vi.fn()}
+			playing={false}
+			onTogglePlay={vi.fn()}
+			onPrevClip={vi.fn()}
+			onNextClip={vi.fn()}
+			onEditClip={vi.fn()}
+		/>,
+	);
+	return {
+		pill: screen.getByTitle("toolbar.newAnnotation"),
+		clipEls: Array.from(document.querySelectorAll<HTMLElement>("[data-clip-id]")),
+		tl,
+	};
+}
+
+/** Drag a handle by `dxPx`. The move/up listeners live on `window`, so the drag
+ *  is driven by pointer deltas alone — the handle may re-mount under it. */
+function dragHandle(handle: Element, dxPx: number) {
+	fireEvent.pointerDown(handle, { clientX: 0 });
+	window.dispatchEvent(new MouseEvent("pointermove", { clientX: dxPx }));
+	window.dispatchEvent(new MouseEvent("pointerup", { clientX: dxPx }));
+}
+
+/** Ctrl+wheel up = zoom in; the handler is a native listener, so dispatch real events. */
+function zoomIn(notches: number) {
+	const canvas = document.querySelector("[class*=tlTracks]") as HTMLElement;
+	for (let i = 0; i < notches; i++) {
+		fireEvent.wheel(canvas, { ctrlKey: true, deltaY: -100, clientX: 0 });
+	}
+}
+
+describe("V4Timeline lane pills", () => {
+	it("draws a pill exactly as wide as its region, at any zoom", () => {
+		// 1 s of 1800 s. The old `Math.max(1.5, …)` floor drew this as 1.5% — 27
+		// seconds of ruler for a one-second annotation — and did it at every zoom,
+		// since the floor was a percentage of the timeline rather than of the screen.
+		const { pill } = renderTimeline();
+		const expected = (1 / TOTAL_SEC) * 100;
+		expect(Number.parseFloat(pill.style.width)).toBeCloseTo(expected, 6);
+
+		// The canvas is what scales with zoom, so the pill's share of it must not
+		// move at all — only the chrome inside it may react (below).
+		zoomIn(40);
+		expect(Number.parseFloat(pill.style.width)).toBeCloseTo(expected, 6);
+	});
+
+	it("keeps both resize handles reachable when the pill is thinner than they are", () => {
+		// 0.5 px wide at this zoom: the handles cannot sit inside the box without
+		// swallowing it whole, so they mount outside it and the body stays a move
+		// target. Resizing a hairline stays possible — it is the pointer precision
+		// that is coarse there, not the affordance that is missing.
+		const { pill } = renderTimeline();
+		const [left, right] = Array.from(pill.querySelectorAll("span"));
+		expect(left.style.left).toBe("-10px");
+		expect(right.style.right).toBe("-10px");
+		// Nothing legible fits, so no icon/label is rendered (the title attribute
+		// still carries the value on hover).
+		expect(pill.textContent).toBe("");
+
+		// Zoomed to the 50× ceiling the same second is 25 px wide and hosts its own
+		// chrome again.
+		zoomIn(40);
+		expect(left.style.left).toBe("0px");
+		expect(right.style.right).toBe("0px");
+	});
+
+	it("grows and shrinks a hairline pill from its outside handles", () => {
+		// Growing is unbounded by the pill's own size: 90 px right of a 900 px canvas
+		// is a tenth of the 1800 s timeline, so the 10–11 s annotation ends at 191 s.
+		// The chrome re-flows inside the box as it crosses PILL_HANDLES_MIN_PX
+		// mid-drag, which the gesture never notices — the deltas come from the
+		// pointer and the listeners live on `window`, not on the handle.
+		const { pill, tl } = renderTimeline();
+		const [left, right] = Array.from(pill.querySelectorAll("span"));
+		dragHandle(right, 90);
+		expect(tl.updateAnnotationSpan).toHaveBeenCalledWith("ann1", 10_000, 191_000);
+
+		// Shrinking stops at the storage grid (1 ms), not at the old flat 200 ms
+		// floor that refused the last fifth of a second however far you zoomed in.
+		dragHandle(left, 90_000);
+		expect(tl.updateAnnotationSpan).toHaveBeenLastCalledWith("ann1", 10_999, 11_000);
+
+		// 18 s short of the timeline end: 9 px away on screen, so it stays where it
+		// was dropped. The snap radius used to be 1.2% of the timeline — a 21-second
+		// magnet here — which is what made a grown edge jump to a clip boundary it
+		// was nowhere near, the more so the longer the recording.
+		dragHandle(right, 885.5);
+		expect(tl.updateAnnotationSpan).toHaveBeenLastCalledWith("ann1", 10_000, 1_782_000);
+	});
+});
+
+describe("V4Timeline clip row", () => {
+	// Three clips = two junctions. As a flex row with `gap: 6px`, each junction
+	// added 6px while every clip shrank proportionally to pay for it, so a clip's
+	// left edge missed its true start: measured in a browser on this very fixture,
+	// clip 2 by +2px and clip 3 by +6px, while the pills and ruler above them sat
+	// at the true position. Being a fixed px error in a proportional layout, it was
+	// worth 5 s and 15 s of timeline zoomed out but a fraction of a second zoomed
+	// in — which is what reads as "the pills move when I zoom".
+	const CLIPS = [clip(0, 600), clip(600, 900), clip(900, TOTAL_SEC)];
+	const startsAt = (sec: number) => `${(sec / TOTAL_SEC) * 100}%`;
+
+	it("anchors every clip to its own start time, and keeps it there under zoom", () => {
+		// The annotation starts exactly where the second clip does, so the pill and
+		// the clip edge under it must resolve to the very same coordinate.
+		const { clipEls, pill } = renderTimeline(CLIPS, {
+			id: "ann1",
+			startMs: 600_000,
+			endMs: 601_000,
+		});
+		expect(clipEls.map((el) => el.style.left)).toEqual([startsAt(0), startsAt(600), startsAt(900)]);
+		expect(pill.style.left).toBe(clipEls[1].style.left);
+
+		// Zoom scales the canvas these coordinates live in, so the coordinates
+		// themselves must not move: same values, same agreement with the pill.
+		zoomIn(40);
+		expect(clipEls.map((el) => el.style.left)).toEqual([startsAt(0), startsAt(600), startsAt(900)]);
+		expect(pill.style.left).toBe(clipEls[1].style.left);
+	});
+
+	it("takes the card gutter out of each clip's own width", () => {
+		// The 6px is what separates two cards. Taken off the clip's width it stays
+		// local to that clip; inserted between them (a flex gap) it displaced every
+		// clip that followed. The 1px floor keeps a clip shorter than the gutter
+		// from collapsing to nothing on a long timeline.
+		const { clipEls } = renderTimeline(CLIPS);
+		const widths = clipEls.map((el) => el.style.width);
+		// (jsdom re-serialises the percentage to 4 decimals, hence the numeric read)
+		expect(widths.map((w) => w.endsWith("- 6px)"))).toEqual([true, true, true]);
+		for (const [i, durSec] of [600, 300, 900].entries()) {
+			expect(Number.parseFloat(widths[i].slice("calc(".length))).toBeCloseTo(
+				(durSec / TOTAL_SEC) * 100,
+				3,
+			);
+		}
+	});
+});