feat(mise): opt-in Datadog metrics for app token usage#1129
Conversation
![atlassian[bot]](https://avatars.githubusercontent.com/in/14320?s=60&v=4){kind=small}
| { | ||
| "series": [ | ||
| { | ||
| "metric": "devbase.github.app.rate_limit_used", |
There was a problem hiding this comment.
🔎 Acceptance Criteria
The code does not distinguish between Personal Access Token (PAT) and GitHub App token usage. All metrics are reported under 'devbase.github.app.rate_limit_*' metric names, which specifically reference GitHub App tokens rather than PATs. There is no focus on PAT usage as defined in the acceptance criteria.
Details
📖 Explanation: The implementation reports rate limit metrics for any GitHub token without differentiating token types. The metric names (lines 315, 321) use 'github.app' naming, suggesting GitHub App tokens only. No special handling or logging exists for PAT usage as defined in the acceptance criteria.
There was a problem hiding this comment.
It does, that's why it's github.app. (mise only uses the app tokens since they have more allowed API calls per hour.) A future PAT metric would be github.pat.
This comment was marked as low quality.
This comment was marked as low quality.
|
🎉 This PR is included in version 2.37.0-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
What this PR does / why we need it
Adds best-effort Datadog telemetry to
run_miseso we can see how ourGitHub app token's rate-limit budget is spent across CI, sliced by
mise subcommand, repo, and CI job.
Opt-in via
DATADOG_API_KEYin the CI environment; silent no-opotherwise.
Jira ID
DT-5281
Notes for your reviewers
Per-invocation granularity is intentional — it's what lets us attribute
API usage to specific
misesubcommands rather than aggregate per-job.Rovo Dev code review: Rovo Dev has reviewed this pull request
Any suggestions or improvements have been posted as pull request comments.