Skip to content

fix: save cache mozart pipe - wait for password from AWS ECR #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marnagy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: save cache mozart pipe - wait for password from AWS ECR #1131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8037f0
fix: wait for AWS ECR to get password
marnagy Apr 17, 2026
d544742
make fmt && make lint
marnagy Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mise.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion shell/lib/docker/authn/aws-ecr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ ecr_auth() {
region="$(echo "$registry" | cut -d. -f4)"
info_sub "Authenticating with AWS ECR in $registry"
# See: https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html#registry-auth-token
aws ecr get-login-password --region "$region" | docker login --username AWS --password-stdin "$registry"
# Capture the password first to avoid pipe stdin issues in non-TTY CI environments.
ecr_password="$(aws ecr get-login-password --region "$region")"
docker login --username AWS --password-stdin "$registry" <<<"$ecr_password"
}

# ensure_ecr_repository ensures that an ECR repository exists.
Expand Down